-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sip2json pvar #3311
Add sip2json pvar #3311
Conversation
Thank you @vladpaiu . Here is some feedback: "Must" changes:
"Nice to have" change:
If you consider converting this pvar into a function, you may also parametrize it - like an optional parameter with white/black filters to control the headers to be added into JSON. Now, on second thoughts, I see a better option to have this functionality as function in sipmsgops module. |
thanks for the feedback, will make the necessary changes and get back to you here. |
Any updates here? No progress has been made in the last 30 days, marking as stale. |
@vladpaiu, any chances to get the MUST changes (at least) by tomorrow, so we can include this into the 3.5 release on 9th ? |
moved the implementation to sipmsgops and added documentation |
Thank you @vladpaiu - could you add couple of words in the doc about the format of the resulting json? is it like one node per line? or ? Thanks ! |
Summary
Add sip2json pvar
Details
Needed for cases when you want to pass a generic SIP message to a SIP agnostic entity, but still want to provide some layer of SIP parsing before sending the full message further.
Solution
JSON with First line, Headers and Body
Compatibility
Backwards compatible
Special Thanks to Voicenter for sponsoring the work.