Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radial Velocity sign #306

Closed
ecazaubon opened this issue Feb 25, 2019 · 0 comments · Fixed by #378
Closed

Radial Velocity sign #306

ecazaubon opened this issue Feb 25, 2019 · 0 comments · Fixed by #378
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface.
Milestone
v3.2.0

Comments

@ecazaubon
Copy link

open-simulation-interface/osi_featuredata.proto

Line 279 in 94e3d30

// Absolute radial (in direction to the sensor) velocity of the detection.

Why is the radial velocity (which I understood to be a Doppler velocity) an absolute value here ?
@ghost ghost added the Question General questions about the standard, work-flow and code. label Mar 8, 2019
@ghost ghost added this to the v3.1.3 milestone Mar 8, 2019
jdsika added a commit that referenced this issue Feb 19, 2020
@jdsika
Resolves issue #306
da709e8 
- Removed incorrect rule due to misinterpretation of "absolute"
- Improved comment
vkresch pushed a commit that referenced this issue Feb 19, 2020
@jdsika
Resolves issue #306 (#378)
fd88902 
- Removed incorrect rule due to misinterpretation of "absolute"
- Improved comment
@jdsika jdsika mentioned this issue Feb 19, 2020
Merged
6 tasks
@jdsika jdsika added Bug Problems in the build system, build scripts, etc or faults in the interface. and removed Question General questions about the standard, work-flow and code. labels Feb 19, 2020
@jdsika jdsika closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

fix/documentation-radial-velocity OpenSimulationInterface/open-simulation-interface
2 participants
@jdsika @ecazaubon