Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/documentation-radial-velocity #378

Merged
merged 1 commit into from
Feb 19, 2020
Merged

fix/documentation-radial-velocity #378

merged 1 commit into from
Feb 19, 2020

Conversation

jdsika
Copy link
Contributor

@jdsika jdsika commented Feb 19, 2020 •
edited
Loading

Summary

  • Removed incorrect rule due to misinterpretation of the word "absolute"
  • Improved comment so that psoitive values are correctly interpreted
  • Resolves Radial Velocity sign #306

Mention a member

@pmai approve and merge

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@jdsika
Resolves issue #306
da709e8 
- Removed incorrect rule due to misinterpretation of "absolute"
- Improved comment
@jdsika jdsika added Bug Problems in the build system, build scripts, etc or faults in the interface. Documentation Everything which impacts the quality of the documentation and guidelines. labels Feb 19, 2020
@jdsika jdsika added this to the v3.2.0 milestone Feb 19, 2020
@jdsika jdsika requested review from pmai and vkresch February 19, 2020 10:29
@vkresch vkresch merged commit fd88902 into master Feb 19, 2020
@jdsika jdsika changed the title Resolves issue #306 Resolves #306 Feb 19, 2020
@jdsika jdsika changed the title Resolves #306 fix/documentation-radial-velocity Feb 19, 2020
@pmai pmai deleted the bug/documentation-radial-velocity branch April 27, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkresch vkresch vkresch approved these changes

@pmai pmai Awaiting requested review from pmai

Assignees
No one assigned
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. Documentation Everything which impacts the quality of the documentation and guidelines.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Radial Velocity sign
2 participants
@jdsika @vkresch