Skip to content

Extension osi lane #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Extension osi lane #366

wants to merge 8 commits into from

Conversation

0815-code
Copy link
Contributor

Reference to a related issue in the repository

Add a reference to a related issue in the repository.

Add a description

A polyline model was added to the osi_lane.proto to describe the lane boundaries with a polyline up to 3rd order.

Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
It is a feature.

How has it been tested?

Mention a member

@PhRosenberger @ThomasNaderBMW @jdsika

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@0815-code 0815-code requested a review from jdsika January 14, 2020 16:38
@0815-code 0815-code added this to the v3.2.0 milestone Jan 15, 2020
@jdsika jdsika modified the milestones: v3.2.0, v4.0.0 Feb 19, 2020
@0815-code 0815-code linked an issue Feb 23, 2020 that may be closed by this pull request
@kmeids kmeids added FeatureRequest Proposals which enhance the interface or add additional features. TrafficParticipants The group in the ASAM development project working on traffic participants. labels Oct 28, 2020
@kmeids kmeids removed this from the (REMOVE) ASAM OSI x.x.x milestone Oct 28, 2020
Signed-off-by: Schloemicher, Thomas AVL,AT <[email protected]>
@clemenshabedank
Copy link
Contributor

Hello @ThomasSchloemicherAVL let's discuss at your next meeting if this is postponed for major release or introduced in V3.3. I think there is nothing in it that would break backwards compatibility (besides that you can't just switch the enumeration values). But we should discuss if it might be a useful and reasonable field within SensorView/GroundTruth or if we only want to introduce it in osi_detectedlane.proto. The way you implemented it doesn't really make clear which or if both models (boundary points + BoundaryPolyLineModel) should be used.

My opinion would be: Definitely useful for detected lane boundaries, especially with the harmonization with ISO 23150 aspect. For lane boundaries in GroundTruth I am sceptical because it is actually already processed data. But on the other hand it could make calculations easier for Traffic Participants... But I would then tend to take this model as a center line extension because the centerline is already "imaginative data" and is used for guiding traffic participants.

@0815-code 0815-code closed this Feb 12, 2021
@0815-code 0815-code deleted the Extension_osi_lane branch February 12, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features. TrafficParticipants The group in the ASAM development project working on traffic participants.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSI and ISO23150 initiative alignment
5 participants