-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for discussion: Feature/add elements to measurement state #660
Open
FlorianMueller87
wants to merge
6
commits into
OpenSimulationInterface:master
Choose a base branch
from
FlorianMueller87:feature/add_elements_to_MeasurementState
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0c58e6c
Added new elements to MeasurementState
FlorianMueller87 7293b45
Added new element to MeasurementState: INVALID
FlorianMueller87 45f8654
Merge branch 'master' into feature/add_elements_to_MeasurementState
jdsika cb96acb
Corrected type: PREDICED to PREDICTED
54a11b6
Corrected PARTLY typo
e31f016
Merge branch 'master' into feature/add_elements_to_MeasurementState
jdsika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,27 @@ message DetectedItemHeader | |
// Values provided by tracking only. | ||
// | ||
MEASUREMENT_STATE_PREDICTED = 3; | ||
|
||
// This indicates the first occurrence of this particular object in the object list. | ||
// | ||
MEASUREMENT_STATE_NEW = 4; | ||
|
||
// The object was partly updated with new information | ||
// from a sensor in the last update cycle of this object | ||
// list. The measurement was incomplete and could, | ||
// therefore, only partially update the signals of this | ||
// object. The remaining signals of this object are unchanged | ||
// or predicted for this measurement cycle. | ||
// | ||
MEASUREMENT_STATE_PARTIALLY_MEASURED = 5; | ||
|
||
// Tracked object is temporarily occluded by another entity. | ||
// | ||
MEASUREMENT_STATE_PREDICED_OCCLUDED = 6; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prediced or PREDICTED? Where is the differnece to state predicted above? |
||
|
||
// The object is invalid in this cycle. | ||
// | ||
MEASUREMENT_STATE_INVALID = 7; | ||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PARTLY_MEASURED in ISO23150?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PARTLY_MEASURED is correct. This is a mistake on ADI side.