Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
689 add raytracerview config #699
base: master
Are you sure you want to change the base?
689 add raytracerview config #699
Changes from 13 commits
22e2659
0a3bde8
507513e
8bd9721
cae9817
3b4168f
513cd44
8673313
f4f519e
875cd70
96a107f
7dcc5b0
63611e9
6b9b67d
9b5b2d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is prone to errors and other conceptswould be possible like:
repeated double phase
as part of theSpatialSignalGain
aside of therepeated double signal_gain
optional double phase
andoptional double signal_gain
as e.g. a new messagePhaseGain
as part of theSpatialSignalGain
as e.g.repeated PhaseGain phase_gain
Have such options been discussed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second option is implemented because of usage of
SpatialSignalGain
orSpatialSignalStrength
in other messages in OSI likeEmittingStructureAttribute