Skip to content

Move sensor specifics to DetectedItemHeader #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomassedlmayer
Copy link
Contributor

Signed-off-by: Thomas Sedlmayer [email protected]

This addresses #462 and goes beyond by enabling sensor specifics for any detected items. It is a non-backwards compatible alternative to #702.

It is still up to discussion if the sensor specifics should be added to the DetectedItemHeader at all. It also should be discussed in terms of harmonization with ISO23150.

@thomassedlmayer thomassedlmayer added SensorModeling The Group in the ASAM development project working on sensor modeling topics. Harmonisation The Group in the ASAM development project working on harmonisation with other standards. labels Feb 2, 2023
@thomassedlmayer thomassedlmayer added this to the V4.0.0 milestone Feb 2, 2023
@ClemensLinnhoff ClemensLinnhoff added the OpenMSL Required to enable sub-libraries in OpenMSL. label Mar 3, 2023
@yash-shah-asam
Copy link
Member

@thomassedlmayer could you please handle this as the part of 23150 project.

@thomassedlmayer
Copy link
Contributor Author

As discussed in the last sensor modeling project meeting, we agreed that I will modify this PR to only deprecate certain fields instead of removing in order to be backwards compatible (minor release) but also already pave the way for a potential major release.

Before merging anything though, we need to check how this is done in the new ISO23150 release as soon as we get access.

@thomassedlmayer
Copy link
Contributor Author

Closes #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards. OpenMSL Required to enable sub-libraries in OpenMSL. SensorModeling The Group in the ASAM development project working on sensor modeling topics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants