Skip to content

Clarify handling of purely technical IDs #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

Clarify handling of purely technical IDs #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions osi_common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ message Orientation3d
// available address space is exhausted and the specific values have not been in
// use for several time steps. Sensor specific tracking IDs have no restrictions
// and should behave according to the sensor specifications.
// Purely simulation technical IDs, like sensor IDs, are not required to be
// unique among all simulated items, but rather unique within the context of the
// given message type.
//
// The value MAX(uint64) = 2^(64) -1 =
// 0b1111111111111111111111111111111111111111111111111111111111111111 is
Expand Down
1 change: 0 additions & 1 deletion osi_sensorview.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ message SensorView
// which are used in the detected features.
//
// \rules
// is_globally_unique
// is_set
// \endrules
//
Expand Down
2 changes: 1 addition & 1 deletion rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ is_iso_country_code: '^[ ]\b(is_iso_country_code)\b'
first_element: '^[ ]\b(first_element)\b'
last_element: '^[ ]\b(last_element)\b'
check_if: '^[ ](\bcheck_if\b)(.*\belse do_check\b)'
is_set: '^[ ]\b(is_set)\b'
is_set: '^[ ]\b(is_set)\b'