Adapt vehicle types from openx harmonization #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomassedlmayer
added
the
Harmonisation
Signed-off-by: Thomas Sedlmayer <[email protected]>
thomassedlmayer
force-pushed
the
adapt-vehicle-harmonization
branch
from
2b22a42 to
45f045f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to adapt the vehicle type definitions and descriptions that are defined by the OpenX Traffic Participants Specification.
I also replaced the old meaningless ("Vehicle is a car") descriptions with the ones of the OpenX specification.
@yash-shah-asam Could you check if there is a permalink to the OpenX specification, I could use? I think it would be reasonable to include a permalink to the specification and somehow signify that OSI tries to adhere to these definitions.
I think there a still some issues open for discussion:
TYPE_DELIVERY_VANwhich should probably be deprecated (as it contains a role). I added the preferred aliasTYPE_VAN.TYPE_MOTORBIKEcontradicts the naming in the OpenX specification ("Motorcycle"). I added an alias. I'm not sure if we should deprecateTYPE_MOTORBIKEor just keep both.TYPE_MICROMOBILITY_DEVICEwhich includes stand-up scooters but OSI already defines the typeTYPE_STANDUP_SCOOTER. Should it be deprecated? It seems like an issue that in the description of micro-mobility devices the stand-up scooter is even mentioned as an example.Apart from these issues, the changes are relatively straightforward and don't contradict the current OSI definitions from my point of view.
@jakobkaths