Introduce ground truth init configuration #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2021 19:16
Signed-off-by: Habedank Clemens <[email protected]>
Signed-off-by: Habedank Clemens <[email protected]>
clemenshabedank
changed the title
6 tasks
tbleher
reviewed
Jun 24, 2021
|
|
||
| - The Ids of objects in ``OSMPGroundTruthInit`` MUST be identical to the Ids of | ||
| - DEPRECATED: The Ids of objects in ``OSMPGroundTruthInit`` MUST be identical to the Ids of | ||
| the same objects contained in later ``OSMPSensorViewIn`` or other input data. |
There was a problem hiding this comment.
Not sure if this can be deprecated. I wrote this originally (but probably not clearly enough) because dynamic objects can reference static objects. So a MovingObject can have assigned lanes, but the SensorView will not contain these lanes, since they are static. Probably should be rewritten to say that, and to mention that SensorViews may be incomplete on their own, if used together with GroundTruthInit (e.g. currently osi-validator complains on our SensorView messages, since it references lanes which are only in the GroundTruthInit), but that SensorView + GroundTruthInit must be consistent.
tbleher
reviewed
Jun 24, 2021
| by the model during a simulation run. Any dynamic data (e.g. MovingObjects) | ||
| it contains MUST NOT be used and has no specified semantics. | ||
| - ``OSMPGroundTruthInit`` MUST contain all data which is requested by the model | ||
| in ``OSMPGroundTruthInitConfiguration``but MUST NOT contain more data. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Architecture group discussions
Add a description
Introduced a configuration mechanism for GroundTruthInit with FMU packaging. Goes together with OpenSimulationInterface/open-simulation-interface#407
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Mention a member
Add @mentions of the person or team responsible for reviewing proposed changes.
Check the checklist