Skip to content

Attempt to make it responsive #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anubhakushwaha
Copy link
Member

@anubhakushwaha anubhakushwaha commented Dec 27, 2017

Checklist

  • My branch is up-to-date with the upstream pre-dev branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fix partially #207

Brief description of what this PR does.
Attempts to make the web page responsive, this can be achieved by setting the element sizes in percentages rather than pixels as mentioned in this post

If relevant, please include a screenshot.
Different screen sizes
1000

1001

1002

1003

A picture of a cute animal (not mandatory but encouraged):
q

Sorry, something went wrong.

@anubhakushwaha
Copy link
Member Author

@tapasweni-pathak @jarifibrahim I have attempted at making it responsive, please let me know if you know another way of doing it better. Please review.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.269% when pulling d709b62 on anubhakushwaha:makeResponsive into ea6096f on OpenSourceHelpCommunity:predev.

@vaibhavsingh97
Copy link
Member

@anubhakushwaha Can you deploy somewhere and give us the live demo link

@jarifibrahim
Copy link
Member

jarifibrahim commented Dec 28, 2017

@vaibhavsingh97 You could just run do a python manage.py collectstatic followed by python manage.py runserver. We don't have to deploy it just for reviewing.

Copy link
Member

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @anubhakushwaha . Thanks for the PR :)

Copy link
Member

@tapaswenipathak tapaswenipathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..and knew the magic of using % or em instead of specifying px. Great you picked % over em. 👍 I checked off one todo from here too. 🎉

You might want to try it on bigger screens too, the odd child's triangle will move away/extra padding from the rectangle. Let me know if you have questions for this or I'll take care of this before merging.

@tapaswenipathak
Copy link
Member

^ 🐼 😄

@anubhakushwaha
Copy link
Member Author

@tapasweni-pathak Sure, will update you on this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.269% when pulling 16458ca on anubhakushwaha:makeResponsive into 3741eed on OpenSourceHelpCommunity:predev.

@anubhakushwaha
Copy link
Member Author

anubhakushwaha commented Jan 6, 2018

@tapasweni-pathak I tested by zooming in the screen and it works well there as well as the
right: and left: are relative to the rectangles. Let me know if I understood something wrong 🍂
screenshot from 2018-01-06 13-19-36

@tapaswenipathak
Copy link
Member

tapaswenipathak commented Jan 6, 2018

👋 @anubhakushwaha, can you try with zooming out?

Edit: One extra 👀 I see this issue on my localhost but not with our live urls. 😕

@tapaswenipathak
Copy link
Member

For some reason I only see it on different browsers in localhost and not on heroku on different browsers. Can someone please check it on how does it look on IE? Merging this, thanks for the work @anubhakushwaha 🎉.

@tapaswenipathak
Copy link
Member

By the way you event made your commit message as an attempt [..], :D

@tapaswenipathak tapaswenipathak merged commit 50e3f02 into OpenSourceHelpCommunity:predev Jan 14, 2018
Copy link
Member

@tapaswenipathak tapaswenipathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants