Added ADMINS to settings.py #64
Conversation
|
@Utsal20 Thanks! I'll let @jarifibrahim take a look at it too before merging it. 👍 |
|
@Utsal20 Can you please add @amarlearning ([email protected]) too? and then this can be merged. |
|
@Utsal20 I modified the PR description to read More details here: https://github.com/blog/1506-closing-issues-via-pull-requests, https://help.github.com/articles/closing-issues-via-commit-messages/. |
There was a problem hiding this comment.
LGTM. I'll merge after you add Amar Prakash Pandey ([email protected]) to Admins.
oshc/oshc/settings.py
Outdated
| @@ -24,6 +24,9 @@ | |||
|
|
|||
| ALLOWED_HOSTS = ['*'] | |||
|
|
|||
| # Tuple of people who get error notifications | |||
| ADMINS = [('Tapasweni Pathak','[email protected]'),('Nikhita Raghunath','[email protected]'),('Ibrahim Jarif','[email protected]')] | |||
|
|
|||
There was a problem hiding this comment.
I think we should split the list something like this for better readability. [more read]
ADMINS = [
('Tapasweni Pathak','[email protected]'),
('Nikhita Raghunath','[email protected]'),
('Ibrahim Jarif','[email protected]')
]Extraneous change. Having two consecutive new lines is not a good practice. [more read]
There was a problem hiding this comment.
Thank you for your suggestions!
I just did:
git add oshc/oshc/settings.py
git push -u origin master
Will this be enough? Or is there something I am missing?
|
Can I please merge this one @amarlearning? or you would suggest @Utsal20 to squash commits? 😄 I see it's @Utsal20's first pull request. ✨ |
|
I am merging this sorry, can't wait. Congrats for your first pull request @Utsal20! 🎆 But @Utsal20 there is something as squashing commits in which if you have fixed your previous commit or you have many related commits separate you can squash them as one. I am sure these two would have suggested you to do this before merging, so surely have a read, for all next pull requests you have to. :) |
|
Thank you so much for your support guys! Will do the reading. |
Fixes #49 completed. Admins are added to settings.py