Configuration guide #173
Open
Configuration guide #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonX
added
enhancement
JaxCavalera
reviewed
Mar 15, 2024
jamesbt365
reviewed
Nov 12, 2024
There was a problem hiding this comment.
While this guide does not directly cover stuff like WinUSB, examples of bad/unopenable lengths and how to handle situations where multiple interfaces have the same lengths (interface attribute required), this is good!
It covers most bases and I don't really have much to be picky about, but heres some stuff I could think of while reading this.
gonX
force-pushed
the
configuration-guide
branch
from
2cc57f0 to
9dffb2d
Compare
We always want a diagnostic file in a PR, reword it so that people can optionally put the report lengths in the commit message
Used the following jq command to extract initialization strings from current configurations in
OpenTabletDriver codebase:
jq '{ name: .Name, InitializationStrings: .DigitizerIdentifiers[].InitializationStrings } | select(.InitializationStrings != null)' OpenTabletDriver.Configurations/Configurations/**/*.json
The following jq command was used to print out the device strings:
jq '{ name: .Name, DeviceStrings: .DigitizerIdentifiers[].DeviceStrings } | select(.DeviceStrings != null)' OpenTabletDriver.Configurations/Configurations/**/*.json
Co-authored-by: jamesbt365 <[email protected]>
|
This should be ready to review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
(screenshot is with #262 included)
Looking for fact checking, theming issues and TODO fixes.
Necessary fixes before merge: