Draft: Add setMetadataJSON() and getMetadataJSON() methods#81
Open
jminor wants to merge 1 commit intoOpenTimelineIO:mainfrom
Open
Draft: Add setMetadataJSON() and getMetadataJSON() methods#81jminor wants to merge 1 commit intoOpenTimelineIO:mainfrom
jminor wants to merge 1 commit intoOpenTimelineIO:mainfrom
Conversation
Signed-off-by: Joshua Minor <joshm@pixar.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is a huge pain to get Swift to serialize and deserialize JSON with the right type checking. For example, when you have a list with a mix of strings and integers, that isn't allowed in Swift, but is in JSON. To make this easier to work with, this PR adds two methods on SerializableObjectWithMetadata:
setMetadataJSON(jsonString, key)getMetadataJSON(key) -> StringThese functions work with raw JSON strings instead of Swift native datatypes. This allows the caller to deal with those strings in any manner they wish.