-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): refactor into two workflow files #321
Conversation
修改后的 ci 能够在 release 时获取到 tag 吗?手动触发时,${{ github.ref }} 会获取到怎样的信息? |
理论上来说手动触发时 ${{ github.ref }} 应该为空,push时应该能获取到分支版本 |
实际试了一下手动触发时为refs/heads/main,push带tag推送为refs/tags/x.x.x |
近期将会再次审阅,请等待我们做更多的验证保证 ci 有效 |
如果单个ci不行的话拆成两个ci也行 |
来自 o1 的 review: 您已经成功地将三个 CI 文件合并为一个,但在合并过程中存在一些问题和遗漏,需要修正:
建议的解决方案:
通过解决上述问题,您将能够成功地将三个 CI 文件合并为一个,同时确保所有功能正常运行。 |
已收到你的更新,我们将会在下一次发版的时候测试 CI 能否正常运行。下一次发版可能在 1-2 周后。 |
@dabao1955 能否尝试 fork 一份 WebGAL Terre,然后完成一个简单的 PR-Merge-发布(打 Tag)流程,以便我们验证该流程是否能够符合我们的目标? |
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.5. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.5) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
test:
name: test
runs-on: ubuntu-latest
if: github.event_name == 'workflow_dispatch' || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/'))
steps:
- run: echo ${{ github.ref }} 我测试了一下,发现提交到main分支后提示 |
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
@dabao1955 请解决一下冲突 |
…ges/WebGAL-electron/cross-spawn-7.0.6 chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /packages/WebGAL-electron
…-spawn-7.0.5 chore(deps): bump cross-spawn from 7.0.3 to 7.0.5
release.yml 删除了所有构建的脚本,那么现在这个 workflow 有前置条件吗,构建产物是如何获取的? |
关于您的疑问,这是build-terre.yml的开头: name: Build WebGAL Terre
on:
workflow_dispatch:
push:
branches:
- main
pull_request:
types:
- opened
- reopened
- synchronize 这是release.yml的开头: name: Release WebGAL Terre
on:
workflow_dispatch:
push:
tags:
- '*.*'
jobs:
release:
name: Release
runs-on: ubuntu-latest
needs: ['build-linux','build-arm64','build-mac','build-windows','build-windows-nsis']
steps:
|
|
已修复,请检查@MakinoharaShoko |
refactor(ci): refactor into two workflow files
refactor(ci): refactor into two workflow files
No description provided.