Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(DataStorage): modify data name of ECC encode unit in DS #342

Merged
merged 3 commits into from
Feb 8, 2025
Merged

chore(DataStorage): modify data name of ECC encode unit in DS #342

merged 3 commits into from
Feb 8, 2025

Conversation

Ma-YX
Copy link
Contributor

@Ma-YX Ma-YX commented Jan 20, 2025

In this pr:

  • Modify data name of ECC encode unit in DS.
    Previous, blockBytes is wrongly used, now replaced by eccDataBlockBits
  • Parameterize 4 to eccDataBankSplit

@Ma-YX Ma-YX requested a review from linjuanZ February 3, 2025 01:56
@linjuanZ linjuanZ merged commit 0922631 into master Feb 8, 2025
1 check passed
@linjuanZ linjuanZ deleted the fix-ecc branch February 8, 2025 12:17
@linjuanZ linjuanZ mentioned this pull request Feb 8, 2025
Merged
linjuanZ added a commit to OpenXiangShan/XiangShan that referenced this pull request Feb 11, 2025
@linjuanZ
submodule(CoupledL2): bump CoupledL2 (#4250)
c41f725 
This pr includes:
- OpenXiangShan/CoupledL2#344
- OpenXiangShan/CoupledL2#349
- OpenXiangShan/CoupledL2#350
- OpenXiangShan/CoupledL2#342
cyril0124 pushed a commit to cyril0124/CoupledL2 that referenced this pull request Feb 13, 2025
@Ma-YX @linjuanZ @cyril0124
chore(DataStorage): modify data name of ECC encode unit in DS (OpenXi…
4266933 
…angShan#342)

Co-authored-by: zhanglinjuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjuanZ linjuanZ linjuanZ approved these changes

@Ivyfeather Ivyfeather Awaiting requested review from Ivyfeather Ivyfeather is a code owner

@Kumonda221-CrO3 Kumonda221-CrO3 Awaiting requested review from Kumonda221-CrO3 Kumonda221-CrO3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ma-YX @linjuanZ