timing(LoadUnit): adjust rar/raw query valid generate logic #4218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadQueueRAR
andLoadQueueRAW
need to use thevalid
signal of the query to select the index of the queue at load units2
fromFreeList
(because ofFreeList
setenablePreAlloc
). It can put all conditions exceptfast replay
ins3
for judgment (fast replay
can fix #4149). If other conditions are setted ins3
,LoadQueueRAR
andLoadQueueRAW
can revoke the corresponding entry. This is timing friendly, can eliminate 4 levels of logic for query valid generate, and does not add additional logic ins3