fix(elfloader): Sort phdr entries by paddr before return to readFromElf()
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poemonsense
previously approved these changes
Feb 9, 2025
…Elf()` The `readFromElf()` relies on all phdr entries are sorted by paddr, which is not mandatory for the ELF format. We must sort the parsed `sections` before return back to `readFromElf()`. Signed-off-by: Jiuyue Ma <[email protected]>
forever043
force-pushed
the
elf_sort_phdr
branch
from
e314b72 to
ed2f53f
Compare
poemonsense
approved these changes
Feb 9, 2025
|
should we merge this now? |
ready-to-merge :) |
klin02
added a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Feb 10, 2025
* commit: b537f528bbb9e400b9d0da8756219a5f6d107be9 Including: * fix(xdma): remove replicate data parsing when USE_THREAD_MEMPOOL (OpenXiangShan/difftest#555) * Preprocess: move from Gateway to seperate file (OpenXiangShan/difftest#559) * Batch: collect from different groups in one cycle to reduce gates (OpenXiangShan/difftest#558) * feat(query): support query for difftest-dpic data (OpenXiangShan/difftest#557) * PerfCnt: count and sum for each DiffState when Batch (OpenXiangShan/difftest#560) * Preprocess: skip loadEvent for single-core (OpenXiangShan/difftest#561) * vcs: Refact DifftestEndpoint by split large always-block into piece (OpenXiangShan/difftest#565) * vcs: Ensure correct execution order of difftest DPI calls (OpenXiangShan/difftest#563) * Batch: disable split strategy for FPGA to reduce gates (OpenXiangShan/difftest#562) * fix(elfloader): Sort phdr entries by paddr before return to readFromElf() (OpenXiangShan/difftest#566) * Batch: rename BatchInterval to BatchStep, move to tail of StepInfo (OpenXiangShan/difftest#564)
BNWeee
pushed a commit
to OpenXiangShan-Nanhu/difftest
that referenced
this pull request
Feb 13, 2025
…Elf()` (OpenXiangShan#566) The `readFromElf()` relies on all phdr entries are sorted by paddr, which is not mandatory for the ELF format. We must sort the parsed `sections` before return back to `readFromElf()`. Signed-off-by: Jiuyue Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
readFromElf()relies on all phdr entries are sorted by paddr, which is not mandatory for the ELF format. We must sort the parsedsectionsbefore return back toreadFromElf().