Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed contract name update logic #1344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xbryer
Copy link

@0xbryer 0xbryer commented Feb 22, 2025

I corrected an issue where the update() method was incorrectly used with a list of tuples. Since we only need to update a single field, I replaced it with direct assignment. This prevents the TypeError and ensures contract names are updated correctly.

Also, I adjusted the remove_prefix_from_names function to reflect this fix.

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (32dd529) to head (1f7a06d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1344   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          81       81           
  Lines        3496     3496           
=======================================
  Hits         3126     3126           
  Misses        370      370           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32dd529...1f7a06d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant