Add non-value types in EnumerableSet and EnumerableMap #5658
Conversation
🦋 Changeset detectedLatest commit: 326c466 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
force-pushed
the
feature/enumerable-extended
branch
from
f1ae7d6 to
80edba8
Compare
ernestognw
force-pushed
the
feature/enumerable-extended
branch
from
29c48d9 to
6508e9b
Compare
ernestognw
force-pushed
the
feature/enumerable-extended
branch
from
ba06447 to
e412bd9
Compare
|
The reason for the name But since we are moving the code from community to here, we should put all that in the existing library and not create new ones. |
|
Note: this is actually very close to #5558 that was closed when we decided to put these structs in the community repo. |
Amxx
changed the title
| .flatMap((keyType, _, array) => array.map(valueType => ({ key: { type: keyType }, value: { type: valueType } }))) | ||
| .slice(0, -1), // remove bytes32 → bytes32 (last one) that is already defined | ||
| // non-value type maps | ||
| { key: { type: 'bytes', memory: true }, value: { type: 'uint256' } }, |
There was a problem hiding this comment.
do we want to keep this one ?
There was a problem hiding this comment.
Nah, let's remove it and just keep bytes to bytes for now given is the most generic version.
We could theoretically do all variants for ['uint256', 'address', 'bytes32', 'bytes', 'string'], but I think it needs more thought.
There was a problem hiding this comment.
Actually, as you mentioned in #5558, Bytes -> Uint would be useful for weights:
BytesToUintMap (usefull for something like an ERC-7093 contract for guardian->weight)
However, weights are just tracked with a mapping in the current SignerMultiERC7913Weighted and equivalent ERC7579MultisigWeighted module.
// Mapping from signer to weight
mapping(bytes signer => uint256) private _weights;
Co-authored-by: Hadrien Croubois <[email protected]>
ernestognw
changed the title
Check #5663 before
PR Checklist
npx changeset add)