Skip to content

Update VoteMarket and CampaignRemoteManager addresses. #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

clement-ux
Copy link
Collaborator

@clement-ux clement-ux commented Mar 24, 2025

Description

The addresses for both the CampaignRemoteManager (CRM) and Votemarket (VM) have changed since our last deployment.

Since both campaigns will wrap up at the end of this epoch, let’s make sure to update these addresses! It’s a simple change that will keep everything running smoothly.

Deploy checklist

Governance

Proposal Id: 42156234389363764375112905235831057703591973598288606705868053625320845981000
Proposal Tx: 0x549640a528968a6d97ba5df0475c0cbb60569405e031dd79ad734b86ac4b0d93

[
  [
    "0x514447A1Ef103f3cF4B0fE92A947F071239f2809",
    "0x7B5e7aDEBC2da89912BffE55c86675CeCE59803E",
    "0x514447A1Ef103f3cF4B0fE92A947F071239f2809",
    "0x7B5e7aDEBC2da89912BffE55c86675CeCE59803E"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    },
    {
      "type": "BigNumber",
      "hex": "0x00"
    },
    {
      "type": "BigNumber",
      "hex": "0x00"
    },
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "setCampaignRemoteManager(address)",
    "setCampaignRemoteManager(address)",
    "setVotemarket(address)",
    "setVotemarket(address)"
  ],
  [
    "0x00000000000000000000000053ad4cd1f1e52dd02aa9fc4a8250a1b74f351ca2",
    "0x00000000000000000000000053ad4cd1f1e52dd02aa9fc4a8250a1b74f351ca2",
    "0x0000000000000000000000008c2c5a295450ddff4cb360ca73fccc12243d14d9",
    "0x0000000000000000000000008c2c5a295450ddff4cb360ca73fccc12243d14d9"
  ]
]

Two reviewers complete the following checklist:

- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.57%. Comparing base (9c28ced) to head (a13e8ff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2461   +/-   ##
=======================================
  Coverage   48.57%   48.57%           
=======================================
  Files          92       92           
  Lines        4537     4537           
  Branches     1198     1198           
=======================================
  Hits         2204     2204           
  Misses       2330     2330           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clement-ux clement-ux changed the title feat: Update VoteMarket and CampaignRemoteManager addresses for TriOG… Update VoteMarket and CampaignRemoteManager addresses. Mar 25, 2025
@clement-ux clement-ux added the governance Governance related things label Mar 25, 2025
sparrowDom
sparrowDom previously approved these changes Mar 26, 2025
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clement-ux clement-ux requested a review from sparrowDom March 31, 2025 13:23
@clement-ux
Copy link
Collaborator Author

As the previous proposal didn't pass governance, I'm pushing a new one with the exact same params.

shahthepro
shahthepro previously approved these changes Apr 2, 2025
Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

@clement-ux clement-ux dismissed stale reviews from shahthepro and sparrowDom via 50a4c26 April 2, 2025 04:59
@clement-ux
Copy link
Collaborator Author

Executed in this TX, it can be merged.

@clement-ux clement-ux merged commit 9ce3df0 into master Apr 7, 2025
15 of 19 checks passed
@clement-ux clement-ux deleted the clement/upgrade-votemarket-addresses branch April 7, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance Governance related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants