-
Notifications
You must be signed in to change notification settings - Fork 85
Update VoteMarket and CampaignRemoteManager addresses. #2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
=======================================
Coverage 48.57% 48.57%
=======================================
Files 92 92
Lines 4537 4537
Branches 1198 1198
=======================================
Hits 2204 2204
Misses 2330 2330
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As the previous proposal didn't pass governance, I'm pushing a new one with the exact same params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Executed in this TX, it can be merged. |
Description
The addresses for both the CampaignRemoteManager (CRM) and Votemarket (VM) have changed since our last deployment.
Since both campaigns will wrap up at the end of this epoch, let’s make sure to update these addresses! It’s a simple change that will keep everything running smoothly.
Deploy checklist
Governance
Proposal Id:
42156234389363764375112905235831057703591973598288606705868053625320845981000
Proposal Tx: 0x549640a528968a6d97ba5df0475c0cbb60569405e031dd79ad734b86ac4b0d93
Two reviewers complete the following checklist: