Skip to content

feat(manager): use Sentry User Feedback API for manager feedback#2743

Open
fortuna wants to merge 5 commits intomasterfrom
fortuna/sentry-feedback-manager
Open

feat(manager): use Sentry User Feedback API for manager feedback#2743
fortuna wants to merge 5 commits intomasterfrom
fortuna/sentry-feedback-manager

Conversation

@fortuna
Copy link
Copy Markdown
Collaborator

@fortuna fortuna commented Apr 8, 2026

Summary

  • Migrates Sentry.captureEventSentry.captureFeedback in outline-contact-us-dialog.ts and app.ts to use the Sentry User Feedback API
  • Removes the preload-based Sentry breadcrumb URL redaction workaround; redaction is now done inline in app.ts where it belongs
  • Upgrades Electron to 30.5.1 and updates related dependencies (@sentry/electron to v7, electron-to-chromium to ^1.5.331, PUPPETEER_CHROMIUM_REVISION to 1274542)
  • Fixes the Chromium version test to resolve electron/package.json from server_manager/node_modules so it picks up Electron 30 even when the client remains on Electron 19

Test plan

  • npm run action server_manager/test — all 18 jasmine specs pass, including the Chromium version check
  • npm run action server_manager/www/test — all 59 Karma tests pass
  • Manual smoke test: open the Manager, trigger the Contact Us dialog, submit feedback, verify it appears in Sentry as a User Feedback entry

🤖 Generated with Claude Code

fortuna and others added 2 commits April 7, 2026 22:22
Migrate from Sentry.captureEvent to Sentry.captureFeedback in both the
contact-us dialog and the legacy feedback path in app.ts. Also removes
the preload-based URL redaction workaround (now done inline in app.ts)
and fixes the Chromium version test to resolve electron from
server_manager's own node_modules, so it works when the client and
server_manager use different Electron versions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fortuna fortuna requested a review from a team as a code owner April 8, 2026 06:28
@github-actions github-actions bot added the size/S label Apr 8, 2026
@fortuna fortuna requested a review from ohnorobo April 8, 2026 06:30
@fortuna fortuna changed the title feat(server_manager): use Sentry User Feedback API for manager feedback feat(manager): use Sentry User Feedback API for manager feedback Apr 9, 2026
Copy link
Copy Markdown
Contributor

@ohnorobo ohnorobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. (minus tiny lint fixes) Thank you for breaking it out from the client change.

Nevertheless please DO NOT MERGE this until I've finished a clean 1.20.0 release across platforms. I want to shake out any remaining unknown-unknowns from the transfer process before we add an electron upgrade on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants