WIP 3d by PhilipDeegan · Pull Request #1100 · PHAREHUB/PHARE

PhilipDeegan · 2025-11-05T12:13:44Z

not ready, just here for TC tests

coderabbitai · 2025-11-05T12:13:54Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)

WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tests/diagnostic/test-diagnostics_3d.cpp

+    electromag_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, allFromPython)


tests/diagnostic/test-diagnostics_3d.cpp

+    particles_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, electromag)


tests/diagnostic/test-diagnostics_3d.cpp

+    fluid_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, particles)


tests/diagnostic/test-diagnostics_3d.cpp

+static std::string const job_file = "job_3d";
+static std::string const out_dir  = "phare_outputs/diags_3d/";
+
+TYPED_TEST(Simulator3dTest, fluid)


tests/diagnostic/test-diagnostics_3d.cpp

+
+#include "core/def/phare_mpi.hpp"
+
+#include "test_diagnostics.ipp"


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp

                auto& J  = hybridModel.state.J;
                auto& Vi = hybridModel.state.ions.velocity();
                auto& Ni = hybridModel.state.ions.chargeDensity();
+                auto& E  = hybridModel.state.electromag.E;


src/amr/data/particles/refine/splitter.hpp

        using FineParticle = decltype(particles[0]); // may be a reference

        core::apply(patterns, [&](auto const& pattern) {
+            auto weight = static_cast<Weight_t>(pattern.weight_);


tests/diagnostic/test-diagnostics_3d.cpp

+    electromag_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, allFromPython)


tests/diagnostic/test-diagnostics_3d.cpp

+    particles_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, electromag)


tests/diagnostic/test-diagnostics_3d.cpp

+    fluid_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, particles)


tests/diagnostic/test-diagnostics_3d.cpp

+static std::string const job_file = "job_3d";
+static std::string const out_dir  = "phare_outputs/diags_3d/";
+
+TYPED_TEST(Simulator3dTest, fluid)


tests/diagnostic/test-diagnostics_3d.cpp

src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                        return std::make_tuple(criter_x, criter_y, criter_z);
+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/core/numerics/pusher/fusher.hpp

+// #include "core/utilities/range/range.hpp"
+// #include "core/data/particles/particle.hpp"


src/core/numerics/pusher/fusher.hpp

src/amr/tagging/default_hybrid_tagger_strategy.hpp

+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);
+                    auto const& [Bz_x, Bz_y, Bz_z] = field_diff(Bz);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);
+                    auto const& [Bz_x, Bz_y, Bz_z] = field_diff(Bz);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);


src/core/data/grid/gridlayout.hpp

src/core/data/field/field_box_span.hpp

+    bool operator==(FieldBoxRows const& that) const { return j == that.j; }
+    bool operator!=(FieldBoxRows const& that) const { return j != that.j; }
+
+    // auto point() const { return Point{k, j, box.lower[2]}; }


src/core/data/field/field_box_span.hpp

tests/core/utilities/box/test_box_span.cpp

+
+        for (auto rowit = slab.begin(); rowit != slab.end(); ++rowit)
+        {
+            auto const& [start, size] = *rowit;


tests/core/utilities/box/test_box_span.cpp

+
+        for (auto rowit = slab.begin(); rowit != slab.end(); ++rowit)
+        {
+            auto const& [start, size] = *rowit;


tests/core/utilities/box/test_box_span.cpp

+
+        for (auto rowit = slab.begin(); rowit != slab.end(); ++rowit)
+        {
+            auto const& [start, size] = *rowit;


src/amr/data/field/refine/field_refine_operator.hpp

+#include "core/utilities/box/box_span.hpp"

-#include "field_linear_refine.hpp"
+// #include "field_linear_refine.hpp"


src/amr/data/field/refine/field_refine_operator.hpp

+        auto s_b_rows = s_b_slabs.begin();
+        for (; s_f_rows != s_f_slabs.end(); ++s_f_rows, ++d_f_rows, ++s_b_rows, ++d_b_rows)
+        {
+            auto const& [d_amr_point, _]  = *d_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        auto s_b_rows = s_b_slabs.begin();
+        for (; s_f_rows != s_f_slabs.end(); ++s_f_rows, ++d_f_rows, ++s_b_rows, ++d_b_rows)
+        {
+            auto const& [d_amr_point, _]  = *d_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        for (; s_f_rows != s_f_slabs.end(); ++s_f_rows, ++d_f_rows, ++s_b_rows, ++d_b_rows)
+        {
+            auto const& [d_amr_point, _]  = *d_b_rows;
+            auto const& [s_amr_point, __] = *s_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        for (; s_f_rows != s_f_slabs.end(); ++s_f_rows, ++d_f_rows, ++s_b_rows, ++d_b_rows)
+        {
+            auto const& [d_amr_point, _]  = *d_b_rows;
+            auto const& [s_amr_point, __] = *s_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        {
+            auto const& [d_amr_point, _]  = *d_b_rows;
+            auto const& [s_amr_point, __] = *s_b_rows;
+            auto&& [d_row, d_lcl_point]   = *d_f_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+            auto const& [d_amr_point, _]  = *d_b_rows;
+            auto const& [s_amr_point, __] = *s_b_rows;
+            auto&& [d_row, d_lcl_point]   = *d_f_rows;
+            auto&& [s_row, s_lcl_point]   = *s_f_rows;


tests/core/utilities/box/test_box_span.cpp

+
+        for (auto rowit = slab.begin(); rowit != slab.end(); ++rowit)
+        {
+            auto const& [start, size] = *rowit;


tests/core/utilities/box/test_box_span.cpp

+
+        for (auto rowit = slab.begin(); rowit != slab.end(); ++rowit)
+        {
+            auto const& [start, size] = *rowit;


tests/core/utilities/box/test_box_span.cpp

+
+        for (auto rowit = slab.begin(); rowit != slab.end(); ++rowit)
+        {
+            auto const& [start, size] = *rowit;


src/amr/data/field/refine/field_refine_operator.hpp


-#include "field_linear_refine.hpp"
+
+// #include "field_linear_refine.hpp"


src/amr/data/field/refine/field_refine_operator.hpp

+        std::size_t row_idx = 0;
+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        std::size_t row_idx = 0;
+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;
+            auto const& [s_amr_point, s_size] = *s_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;
+            auto const& [s_amr_point, s_size] = *s_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+            auto const& [d_amr_point, d_size] = *d_b_rows;
+            auto const& [s_amr_point, s_size] = *s_b_rows;
+
+            auto&& [d_row, d_lcl_point] = *d_f_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+            auto const& [s_amr_point, s_size] = *s_b_rows;
+
+            auto&& [d_row, d_lcl_point] = *d_f_rows;
+            auto&& [s_row, s_lcl_point] = *s_f_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        std::size_t row_idx = 0;
+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        std::size_t row_idx = 0;
+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;
+            auto const& [s_amr_point, s_size] = *s_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+        for (; d_f_rows != d_f_slabs.end(); ++d_f_rows, ++d_b_rows, ++row_idx)
+        {
+            auto const& [d_amr_point, d_size] = *d_b_rows;
+            auto const& [s_amr_point, s_size] = *s_b_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+            auto const& [d_amr_point, d_size] = *d_b_rows;
+            auto const& [s_amr_point, s_size] = *s_b_rows;
+
+            auto&& [d_row, d_lcl_point] = *d_f_rows;


src/amr/data/field/refine/field_refine_operator.hpp

+            auto const& [s_amr_point, s_size] = *s_b_rows;
+
+            auto&& [d_row, d_lcl_point] = *d_f_rows;
+            auto&& [s_row, s_lcl_point] = *s_f_rows;


src/core/utilities/allocators.hpp

+
+    void deallocate(T* const p) noexcept
+    {
+        if (p)


src/amr/data/tensorfield/tensor_field_data.hpp

-            restart_db->putVector("field_" + grids[c].name(), grids[c].vector());
+            restart_db->putDoubleArray("field_" + grids[c].name(), grids[c].data(),
+                                       grids[c].size());
+        // restart_db->putVector("field_" + grids[c].name(), grids[c].vector());


src/core/utilities/allocators.hpp

+
+    void deallocate(T* const p) noexcept
+    {
+        if (p)


src/amr/data/tensorfield/tensor_field_data.hpp

-            restart_db->putVector("field_" + grids[c].name(), grids[c].vector());
+            restart_db->putDoubleArray("field_" + grids[c].name(), grids[c].data(),
+                                       grids[c].size());
+        // restart_db->putVector("field_" + grids[c].name(), grids[c].vector());


PhilipDeegan marked this pull request as draft November 5, 2025 12:13

github-advanced-security bot found potential problems Nov 5, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from e1b7238 to 4de43d2 Compare November 7, 2025 15:11

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

src/core/numerics/pusher/fusher.hpp Outdated

Comment on lines 9 to 10

// #include "core/utilities/range/range.hpp"

// #include "core/data/particles/particle.hpp"

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

src/core/numerics/pusher/fusher.hpp Fixed Show fixed Hide fixed

PhilipDeegan force-pushed the 3d_new branch from 4de43d2 to f525884 Compare November 7, 2025 21:20

PhilipDeegan mentioned this pull request Nov 8, 2025

Update to 3D #960

Draft

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from 08883a9 to d04e167 Compare November 10, 2025 12:55

github-advanced-security bot found potential problems Nov 10, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 14 times, most recently from 76f6bfb to be02045 Compare November 11, 2025 16:42

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

src/core/data/grid/gridlayout.hpp Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

src/core/data/grid/gridlayout.hpp Outdated Show resolved Hide resolved

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from 3ac1981 to a1184f5 Compare February 12, 2026 14:04

github-advanced-security bot found potential problems Feb 12, 2026

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from a6e1ae8 to 0b2224d Compare February 16, 2026 10:17

github-advanced-security bot found potential problems Feb 16, 2026

View reviewed changes

src/core/data/field/field_box_span.hpp Fixed Show fixed Hide fixed

PhilipDeegan force-pushed the 3d_new branch 6 times, most recently from f3011d7 to 36d30b9 Compare February 19, 2026 14:16

github-advanced-security bot found potential problems Feb 20, 2026

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from 4fb4ce8 to df46bec Compare February 21, 2026 13:10

github-advanced-security bot found potential problems Feb 21, 2026

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 4 times, most recently from b777a75 to 34bcf85 Compare February 24, 2026 13:07

github-advanced-security bot found potential problems Feb 24, 2026

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from e4f162d to 428cf99 Compare February 24, 2026 16:06

PhilipDeegan added 4 commits February 24, 2026 17:07

compare ghosts boxes when possible

4e080e8

3d...

ffc5fcf

try

06bf30e

++

9b4ddf5

PhilipDeegan force-pushed the 3d_new branch from 428cf99 to 9b4ddf5 Compare February 24, 2026 16:11

github-advanced-security bot found potential problems Feb 24, 2026

View reviewed changes


		#include "core/def/phare_mpi.hpp"

		#include "test_diagnostics.ipp"

		// #include "core/utilities/range/range.hpp"
		// #include "core/data/particles/particle.hpp"


		#include "field_linear_refine.hpp"

		// #include "field_linear_refine.hpp"

Conversation

PhilipDeegan commented Nov 5, 2025

Uh oh!

coderabbitai bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

Uh oh!

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Nov 5, 2025 •

edited

Loading