Use promise for API calls and remove custom extensions#1335
Merged
Conversation
This was referenced Jul 12, 2026
Closed
# Conflicts: # src/Moryx.Operators.Web/app/src/app/operator-details/operator-details.ts # src/Moryx.Operators.Web/app/src/app/services/app-store.service.ts # src/Moryx.Shifts.Web/app/src/app/services/assignment.service.ts # src/Moryx.Workplans.Web/app/src/app/components/sessions/editor/editor.ts # src/Moryx.Workplans.Web/app/src/app/components/sessions/editor/node-properties/node-properties.ts
1nf0rmagician
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #1061
based on #1330
The ng-openapi-gen configuration has been switched to
"promises": trueacross all API services. This aligns the generated code with how it was already consumed. The most calls was wrapping the Observable inlastValueFrom()or.toAsync()anyway.The custom
observable.extensions.tsfiles (which added.toAsync()toObservable) have been deleted.Unnecessary
async/awaitwrappers on single-statement.then()/.catch()callbacks have been cleane. Same idea as avoiding redundant state machines in C#.