Skip to content

Conversation

@specialtactics
Copy link
Member

@specialtactics specialtactics commented Feb 10, 2025

Blockers

  • Need to wait until orchestra techbench releases version 10

Changes

  • Updates to package for Laravel 12 (mostly CI)
  • Removing PHP 8.1, no longer supported

Todo

  • I've added tests for my changes or tests are not applicable
  • I've added my changes to CHANGELOG.md

@specialtactics
Copy link
Member Author

specialtactics commented Feb 10, 2025

Didn't realise that github would pull in the 10x branch as v10 tag, hah. Okey, this is good news, because everything is actually working fine 🎉

I suggest we tag this as 2.8.0-dev for now, and do final tag once Laravel 12 is released.

@Messhias
Copy link
Collaborator

I'll leave it open until the L12 is not released yet. Or do you need to us release it now?

@specialtactics
Copy link
Member Author

Hey @Messhias I think it's wise to not tag final until laravel 12 is released, but my suggestion is we just merge and tag as 2.8.0-dev for now, so that downstream packages (I have one of my own!) can use it in their update process.

Copy link
Contributor

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO: we can merge & tag this as 2.8.0 "as is", the risk is very small.

And if there's another issue, we just push out 2.8.1 or wahtever.

But there's no need for *-dev, things are working fine and it gives other quicker a chance to upgrade 👍🏼

@Messhias
Copy link
Collaborator

It's possible to us first merge this one -> #278

@Messhias Messhias merged commit 1365f0c into main Feb 10, 2025
20 checks passed
@Messhias Messhias deleted the feature/Laravel-12-Support branch February 10, 2025 21:11
@specialtactics
Copy link
Member Author

Awesome, thanks guys I will update the releaselog with the other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants