Skip to content

Draft: Adds strong typing, more typing, php 8.2 features #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

specialtactics
Copy link
Member

@specialtactics specialtactics commented Feb 10, 2025

This is an early draft at this stage.

The aim is to address some recent challenges with the typing of some config ints in a backwards-compatible way, while also adding typing in various places where reasonable.

Discussion Points

  • Since this will involve change of the public API of the package (contracts and things), I think a major version may be a in order? It's entirely possible that someone using this package will have a broken install after this update.
  • Do we want to continue to support Lumen? Laravel themselves have moved away from it, and it hasn't had a major version since v10 (ie. side by side with Laravel 10). This may be a good opportunity to drop support for it, if we do bump major version.

Changes Beyond types

  • Custom Claims
    Renamed the function "customClaims" to "getCustomClaims" to be in line with "setCustomClaims". I kept the current one, just marked as deprecated.

@mfn
Copy link
Contributor

mfn commented Feb 11, 2025

This is an early draft at this stage.

You can also use githubs feature and actually turn it into a draft PR, gives better immediate visibility:
image

@Messhias Messhias marked this pull request as draft February 11, 2025 10:12
@Messhias
Copy link
Collaborator

This is an early draft at this stage.

You can also use githubs feature and actually turn it into a draft PR, gives better immediate visibility: image

I converted to draft for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants