Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract mapping functionality into Mapper classes #25

Closed
Miljar opened this issue Mar 25, 2015 · 1 comment
Closed

Extract mapping functionality into Mapper classes #25

Miljar opened this issue Mar 25, 2015 · 1 comment
Assignees
@Miljar
Labels
Easy pick Enhancement
Milestone
v0.4

Comments

@Miljar
Copy link
Collaborator

Miljar commented Mar 25, 2015

The mapData method & functionality should be moved to specialized Mapper classes. Calls to this method should be replaced by using these Mapper classes.
@Miljar Miljar added this to the v0.4 milestone Mar 25, 2015
@Miljar Miljar self-assigned this Mar 28, 2015
@Miljar
Copy link
Collaborator Author

Miljar commented Apr 3, 2015

Extracted mapping to Mapper classes.
Then extracted hydration of Exif objects to Hydrator classes

Got carried away and made sure unit test coverage is at 100%

@Miljar Miljar closed this as completed Apr 3, 2015
@coveralls coveralls mentioned this issue Apr 3, 2015
Merged
Miljar added a commit that referenced this issue Apr 3, 2015
@Miljar
Merge pull request #33 from Miljar/issues/#25
f29d0e5 
Issues/#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miljar Miljar

Labels
Easy pick Enhancement
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@Miljar