Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/#25 #33

Merged
merged 37 commits into from
Apr 3, 2015
Merged

Issues/#25 #33

merged 37 commits into from
Apr 3, 2015

Conversation

Miljar
Copy link
Collaborator

@Miljar Miljar commented Apr 3, 2015

No description provided.

Tom Van Herreweghe added 30 commits April 3, 2015 13:13
Add Mutator Hydrator for hydrating Exif objects
cabf6a3 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add separate mappers for mapping data to Exif object format
8f6cdc0 
Signed-off-by: Tom Van Herreweghe <[email protected]>
AdapterAbstract now uses Hydrator for setOptions; Removed obsolete me…
bf6ad93 
…thods

Signed-off-by: Tom Van Herreweghe <[email protected]>
Extracted mapping of ExifTool data to separate mapper & updated Exift…
bb6f4e2 
…ool adapter to use that mapper

Signed-off-by: Tom Van Herreweghe <[email protected]>
Extracted mapping of native data to separate mapper & updatd Native a…
ae92380 
…dapter to use that mapper

Signed-off-by: Tom Van Herreweghe <[email protected]>
Bugfixed some small inconsistencies
0ba6276 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Added mutators to Exif class & updated unit tests
fb7763f 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Removed blank lines to conform to PSR2
ec812d9 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add unit test for Exiftool::setNumeric
3c36d12 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add extra unit tests for Reader class
2daf6e1 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add some tests for Exif class
a288667 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Remove strict coverage option
d16cacb 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Made coverage more explicit
4e0ee69 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add @Covers annotation for Exif tests
5eb8ca5 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add unit tests for Mutator class
cf21a3f 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add extra unit tests for AdapterAbstract
2b7fbc6 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add coverage for interfaces & exceptions
281aebd 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Beter interface coverage?
8214151 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add coverage ignore tags
f4eaad8 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add unit test for Exif mutators
836ac7c 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Improved coverage annotations on Exif class
06a75fd 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Removed unnecessary initialization of variable in Reader class
52bbeef 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Removed indenting level in Native mapper class
8fca517 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Improved docblocks & removed unused variable
5899952 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Changed docblocks for AbstractAdapter constructor
32b4358 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Removed obsolete ; in docblocks
874d645 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Unit tests for Exiftool mapper
86c4dac 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Removed incorrect coverage tag
7b16cd4 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Unit test for Native mapper
a2a0272 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Exclude Interfaces from coverage report
cc6fbb7 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Tom Van Herreweghe added 7 commits April 3, 2015 13:16
Added @Covers annotation for the NoAdapterException
6dbc594 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Tried mocking proc_open function for coverage
a862bea 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Corrected stubbing of root function
795fab5 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Add GPS code
476367b 
Signed-off-by: Tom Van Herreweghe <[email protected]>
More unit tests for Exif (GPS added)
1e2e623 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Unit tests for GPS stuff
401686c 
Signed-off-by: Tom Van Herreweghe <[email protected]>
Covered extra paths for Exiftool mapper test
1d4a96b 
Signed-off-by: Tom Van Herreweghe <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage increased (+3.48%) to 100.0% when pulling 1d4a96b on issues/#25 into fe64685 on rel/v0.4.0.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+3.48%) to 100.0% when pulling 1d4a96b on issues/#25 into fe64685 on rel/v0.4.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.48%) to 100.0% when pulling 1d4a96b on issues/#25 into fe64685 on rel/v0.4.0.

Miljar added a commit that referenced this pull request Apr 3, 2015
@Miljar
Merge pull request #33 from Miljar/issues/#25
f29d0e5 
Issues/#25
@Miljar Miljar merged commit f29d0e5 into rel/v0.4.0 Apr 3, 2015
@Miljar Miljar deleted the issues/#25 branch April 3, 2015 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miljar @coveralls