Skip to content

Added ListItemRun element #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2014
Merged

Added ListItemRun element #235

merged 1 commit into from
May 11, 2014

Conversation

basjan
Copy link
Contributor

@basjan basjan commented May 11, 2014

Following issue #232 I have added a ListItemRun element not to break compatibility with the next release

@ivanlanin ivanlanin added this to the 0.11.0 milestone May 11, 2014
@ivanlanin ivanlanin merged commit 467f15a into PHPOffice:develop May 11, 2014
ivanlanin added a commit that referenced this pull request May 11, 2014
@ivanlanin
Merge branch 'Fixed-conversion' of github.com:basjan/PHPWord into #234-…
fc66030 
…#235-basjan
ivanlanin added a commit that referenced this pull request May 11, 2014
@ivanlanin
Merge branch 'ListItemRun' of github.com:basjan/PHPWord into #234-#235-…
da77ba6 
…basjan
ivanlanin added a commit that referenced this pull request May 11, 2014
@ivanlanin
Merge branch '#234-#235-basjan' into develop
27d18fd
@ivanlanin
Copy link
Contributor

Hi @basjan. I just realize that the $fontStyle parameter of function ListItemRun($depth, $fontStyle, $listStyle, $paragraphStyle) was not used because ListItemRun inherits TextRun and TextRun only accept $paragraphStyle. I've removed the parameter, so the function is now ListItemRun($depth, $listStyle, $paragraphStyle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ivanlanin ivanlanin

Labels
Change Request
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@basjan @ivanlanin