Background and border color transparency support for textboxes when color is undefined #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. its woking. |
Progi1984
requested changes
Feb 12, 2025
There was a problem hiding this comment.
@Chudy20007 Could you add some unit tests and update the changelog, please ?
Progi1984
added
the
Status: Waiting for feedback
Chudy20007
force-pushed
the
transparent-textbox
branch
from
59ed844 to
cf4a027
Compare
Chudy20007
force-pushed
the
transparent-textbox
branch
2 times, most recently
from
3c61539 to
e123278
Compare
…olor is undefined
Chudy20007
force-pushed
the
transparent-textbox
branch
from
e123278 to
1e5098f
Compare
Progi1984
approved these changes
Feb 12, 2025
Progi1984
removed
the
Status: Waiting for feedback
|
@Chudy20007 Thank you for your contribution 🥳 |
MichaelPFrey
pushed a commit
to MichaelPFrey/PHPWord
that referenced
this pull request
Feb 15, 2025
…olor is undefined (PHPOffice#2555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In project we use text boxes for imprints and side notes on a word document. It's currently not possible to use non-white background with border. As a simple fix I implement simple check if border or background color is set - if not then text box should be rendered with a transparent colors, else current behavior will be used.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported