Fix that style objects cannot be passed to element constructors #2685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I generally prefer to use style objects over style arrays in elements. But, if you pass a
\PhpOffice\PhpWord\Style\Cellstyle element to the\PhpOffice\PhpWord\Element\Cellconstructor then the$returnObject: trueargument of thesetNewStyle()method in the constructor completely ignores the passed style element, because thesetNewStyle()method only checks if$styleValueis an array and returns$styleObjectas empty style object otherwise. Imho, if$styleValueis a style object with the same type as$styleObjectthen the$returnObject: trueshould also be "ignored" and the passed style object should then be returned instead of the empty base style object.Fixes # (issue)
Checklist:
I have updated the documentation to describe the changes(not applicable, bugfix did not change the behavior)