Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Processor: Fix 0 considered as empty string #2748

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Feb 12, 2025

Description

Template Processor: Fix 0 considered as empty string

Fixes #2572
Fixes #2703

Thanks @cavasinf & @SnipsMine

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@Progi1984 Progi1984 added this to the 1.4.0 milestone Feb 12, 2025
@Progi1984 Progi1984 merged commit 66f0a2c into master Feb 12, 2025
57 checks passed
@Progi1984 Progi1984 deleted the pr2617 branch February 12, 2025 12:00
@Progi1984
Copy link
Member Author

Thanks @cavasinf & @SnipsMine for yours contributions.

MichaelPFrey pushed a commit to MichaelPFrey/PHPWord that referenced this pull request Feb 15, 2025
* Fix `0` considered as empty string

* Update changelog

* Updated changelog & Added unit test

---------

Co-authored-by: Florian CAVASIN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants