Skip to content

Phpstan 10 and IterableValue Prep Part 2#4447

Merged
oleibman merged 3 commits into
PHPOffice:masterfrom
oleibman:stan1002
Apr 23, 2025
Merged

Phpstan 10 and IterableValue Prep Part 2#4447
oleibman merged 3 commits into
PHPOffice:masterfrom
oleibman:stan1002

Conversation

@oleibman

Copy link
Copy Markdown
Collaborator

There will probably be dozens, if not hundreds, of these before I'm ready to commit.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • code quality

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

There will probably be dozens, if not hundreds, of these before I'm ready to commit.
@oleibman

Copy link
Copy Markdown
Collaborator Author

Scrutinizer "failure condition" is a false positive, and is now suppressed.

@oleibman oleibman added this pull request to the merge queue Apr 23, 2025
Merged via the queue into PHPOffice:master with commit 3c7afe6 Apr 23, 2025
@oleibman oleibman deleted the stan1002 branch April 23, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant