Skip to content

【MIIT program】add GDI-NN models - #294

Open
dcx183-maker wants to merge 7 commits into
PaddlePaddle:developfrom
dcx183-maker:add-gdinn
Open

【MIIT program】add GDI-NN models #294
dcx183-maker wants to merge 7 commits into
PaddlePaddle:developfrom
dcx183-maker:add-gdinn

Conversation

@dcx183-maker

@dcx183-maker dcx183-maker commented Jun 16, 2026

Copy link
Copy Markdown

GE-GNN Binary Activity Coefficient Prediction

Added

  • GEGNN: predicts binary-mixture log activity coefficients from excess Gibbs free energy.
  • BinaryActivityDataset: PaddleMaterials-style dataset using the standard path interface.
  • GE-GNN training configuration, reproducibility README, prediction entry, and Paddle unit tests.

Dataset

BinaryActivityDataset accepts path for the binary-mixture CSV. When the file is absent, it is downloaded through the shared PaddleMaterials dataset cache (~/.paddlemat/datasets); the sibling solvent_list.csv is loaded from the same directory. No datasets or checkpoints are included in this PR.

The default config path can be overridden with PPMAT_DATA_PATH. Dataset layout and required CSV columns are documented in property_prediction/configs/gegnn/README.md.

Validation

  • python -m compileall passed for the modified Python files.
  • YAML configuration parsing passed.
  • git diff --check passed.
  • pytest -q test/test_gegnn.py is currently blocked during test collection by the local environment: paddle_scatter does not export scatter. No test result is claimed from this environment.

Scope

This PR contains only GE-GNN dataset, model, configuration, documentation, prediction integration, and Paddle test changes. It excludes traffic metrics, workflows, architecture documentation, Torch cross-framework tests, data/checkpoint artifacts, and hard-coded local paths.

@CLAassistant

CLAassistant commented Jun 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@dcx183-maker dcx183-maker changed the title feat: add GDI-NN models for binary activity coefficient prediction add GDI-NN models for binary activity coefficient prediction Jun 16, 2026
@dcx183-maker dcx183-maker changed the title add GDI-NN models for binary activity coefficient prediction 【MIIT program】add GDI-NN models Jun 16, 2026
@leeleolay

Copy link
Copy Markdown
Collaborator

辛苦人工检查下提交代码 也按照该规范检查下#258

@dcx183-maker

Copy link
Copy Markdown
Author

重新修改上传

@paddle-bot

paddle-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

Thanks for your contribution!

@paddle-bot paddle-bot Bot added the contributor External developers label Jul 13, 2026
@dcx183-maker

Copy link
Copy Markdown
Author

已同步最新 develop 并解决冲突,GDI-NN 聚焦测试已通过。

Comment thread ppmat/datasets/__init__.py Outdated
pid = os.getpid()
pgid = os.getpgid(os.getpid())
print("main proc {} exit, kill process group " "{}".format(pid, pgid))
logger.warning("Main process %s exiting; killing process group %s.", pid, pgid)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么改动

logger.warning("Main process %s exiting; killing process group %s.", pid, pgid)
os.killpg(pgid, signal.SIGKILL)


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还原

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该文件不符合套件内已有dataset规范

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不符合规范

Comment thread property_prediction/gdinn_predict.py Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不符合规范

Comment thread .gitignore

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcx183-maker

Copy link
Copy Markdown
Author

麻烦再看一下

@leeleolay

Copy link
Copy Markdown
Collaborator

冲突需解决

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有按照已有的数据集格式来写

Integrate Paddle-native GE-GNN training, inference, configuration, and documentation for binary activity coefficients.
Use the standard path-based dataset interface and shared PaddleMaterials data cache.
Keep the shared collator module unchanged because the GE-GNN collator is resolved from its dataset module.
Describe the data file mapping for the published GE-GNN resources.
@leeleolay

Copy link
Copy Markdown
Collaborator

重构了部分基础组件,移动了推理器的位置,辛苦基于新的开发和尝试 @dcx183-maker

Resolve the develop merge conflicts while preserving the GE-GNN dataset, model, binary-mixture inference, configuration, and tests. Keep the new predictor locations and expose the collator through the shared loader interface.
dataset:
__class_name__: BinaryActivityDataset
__init_params__:
path: "${oc.env:PPMAT_DATA_PATH,./data/binary_activity/output_binary_with_inf_all.csv}"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写法不合规

loader:
num_workers: 0
use_shared_memory: False
collate_fn: BinaryActivityCollator

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用default collator

Comment thread ppmat/datasets/gegnn_dataset.py Outdated
Comment on lines +109 to +114
_DATA_URL = (
"https://paddle-org.bj.bcebos.com/paddlematerials/datasets/"
"thermodynamic_data_of_binary_mixtures/"
)
_DATA_FILE = "output_binary_with_inf_all.csv"
_SOLVENT_FILE = "solvent_list.csv"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

格式需纠正

Comment thread ppmat/datasets/gegnn_dataset.py Outdated
_SOLVENT_FILE = "solvent_list.csv"


def smiles_to_pgl_graph(smiles, add_self_loop=True):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用已有的构造graph的功能?参考下moleculargraph是否可以使用

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考mp20dataset.py格式,当前无cache功能,解析路径函数请复用已有的。合理的方式建议copy已有的再做小修改

Use standard molecular graph conversion and caching, default collation, and BasePredictor-compatible inference APIs.
Resolve predictor API conflicts while preserving GE-GNN binary-mixture inference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers MIIT Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants