Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syncfusion_flutter_calendar and date_picker to latest version #2732

Conversation

may-tas
Copy link
Contributor

@may-tas may-tas commented Feb 3, 2025

What kind of change does this PR introduce?

Issue Number:

Did you add tests for your changes?

  • Not required.

  • Tests are written for all changes made in this PR.

  • Test coverage meets or exceeds the current coverage (~90/95%).

Summary

Does this PR introduce a breaking change?

  • No

Checklist for Repository Standards

  • Have you reviewed and implemented all applicable coderaabbitai review suggestions?
  • Have you ensured that the PR aligns with the repository’s contribution guidelines?

Have you read the contributing guide?

  • Yes

Summary by CodeRabbit

  • Chores
    • Removed outdated dependencies no longer needed.
    • Upgraded calendar and datepicker libraries to more recent versions for improved performance and stability.

Copy link
Contributor

coderabbitai bot commented Feb 3, 2025

Walkthrough

This pull request modifies the pubspec.yaml file. It removes two dependencies (_fe_analyzer_shared and custom_lint_builder) and updates the version numbers for two Syncfusion packages (syncfusion_flutter_calendar and syncfusion_flutter_datepicker) from ^27.2.5 to ^28.2.3. No other changes were made to the structure or configuration.

Changes

File Change Summary
pubspec.yaml - Removed dependencies: _fe_analyzer_shared: ^60.0.0, custom_lint_builder: ^0.4.0
- Updated versions: syncfusion_flutter_calendar and syncfusion_flutter_datepicker from ^27.2.5 to ^28.2.3

Assessment against linked issues

Objective Addressed Explanation
Upgrade package syncfusion_flutter_calendar from 27.2.5 to 28.2.3 [#2730]

Possibly related PRs

Suggested reviewers

  • noman2002
  • palisadoes

Poem

A rabbit hops with glee, so bright,
Dependencies pruned, versions set just right.
Carrots and code in a joyful mix,
Bugs vanish under clever tricks.
In every line, a dance of delight!
(_/)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Feb 3, 2025

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@may-tas may-tas changed the title updated syncfusion_flutter_calendar and date_picker Update syncfusion_flutter_calendar and date_picker to latest version Feb 3, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pubspec.yaml (2)

16-20: Clean-up of commented dependency removal.

The commented-out block for _fe_analyzer_shared (and related analyzer lines) is present solely as a removal note. If these dependencies are no longer needed, it would improve clarity and maintainability to remove these commented lines entirely.


33-36: Remove obsolete commented dependency.

The commented-out custom_lint_builder: ^0.4.0 along with its separator is left in the file. To avoid confusion and reduce clutter, consider removing these lines entirely if the dependency is now deemed unnecessary.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa060dc and 9e7f5e7.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pubspec.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Checking codebase
🔇 Additional comments (1)
pubspec.yaml (1)

73-74: Verify updated Syncfusion dependency versions.

The versions for syncfusion_flutter_calendar and syncfusion_flutter_datepicker have been updated to ^28.2.3. Please ensure that these package updates are fully compatible with the current Flutter version and that there are no unintended side effects on calendar or date picker functionalities. Confirm testing coverage on these widgets as part of your regression suite.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (fa060dc) to head (9e7f5e7).
Report is 1 commits behind head on develop-postgres.

Additional details and impacted files
@@                Coverage Diff                @@
##           develop-postgres    #2732   +/-   ##
=================================================
  Coverage             96.37%   96.37%           
=================================================
  Files                   189      189           
  Lines                 10020    10020           
=================================================
  Hits                   9657     9657           
  Misses                  363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@may-tas
Copy link
Contributor Author

may-tas commented Feb 3, 2025

@palisadoes This issue didn’t require any fixes, as my PR #2722 was merged. The issue Dependabot was facing got resolved automatically.
please review and merge.

@palisadoes palisadoes merged commit 3bd8a63 into PalisadoesFoundation:develop-postgres Feb 3, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants