-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syncfusion_flutter_calendar and date_picker to latest version #2732
Update syncfusion_flutter_calendar and date_picker to latest version #2732
Conversation
WalkthroughThis pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pubspec.yaml (2)
16-20
: Clean-up of commented dependency removal.The commented-out block for
_fe_analyzer_shared
(and related analyzer lines) is present solely as a removal note. If these dependencies are no longer needed, it would improve clarity and maintainability to remove these commented lines entirely.
33-36
: Remove obsolete commented dependency.The commented-out
custom_lint_builder: ^0.4.0
along with its separator is left in the file. To avoid confusion and reduce clutter, consider removing these lines entirely if the dependency is now deemed unnecessary.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pubspec.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
pubspec.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Checking codebase
🔇 Additional comments (1)
pubspec.yaml (1)
73-74
: Verify updated Syncfusion dependency versions.The versions for
syncfusion_flutter_calendar
andsyncfusion_flutter_datepicker
have been updated to^28.2.3
. Please ensure that these package updates are fully compatible with the current Flutter version and that there are no unintended side effects on calendar or date picker functionalities. Confirm testing coverage on these widgets as part of your regression suite.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2732 +/- ##
=================================================
Coverage 96.37% 96.37%
=================================================
Files 189 189
Lines 10020 10020
=================================================
Hits 9657 9657
Misses 363 363 ☔ View full report in Codecov by Sentry. |
@palisadoes This issue didn’t require any fixes, as my PR #2722 was merged. The issue Dependabot was facing got resolved automatically. |
3bd8a63
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Issue Number:
syncfusion_flutter_calendar
from 27.2.5 to 28.2.3 #2730Did you add tests for your changes?
Not required.
Tests are written for all changes made in this PR.
Test coverage meets or exceeds the current coverage (~90/95%).
Summary
Does this PR introduce a breaking change?
Checklist for Repository Standards
coderaabbitai
review suggestions?Have you read the contributing guide?
Summary by CodeRabbit