Skip to content

Add support for Now and Again #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add support for Now and Again #483

wants to merge 3 commits into from

Conversation

igorwessel
Copy link
Contributor

@igorwessel igorwessel commented Jan 20, 2025

Partially Fixes #180, still need slow magnitude and the slow effect in presence to finish Chronomancer implementation.

Description of the problem being solved:

Add support for Now and Again from Chronomancer.

I'm still not sure if it's worth include in DPS calculations...
But currently I just add in Skill Cooldown, the Effective Cooldown breakdown.

Add new General Config for change how calculate the cooldown.

Link to a build that showcases this PR:

eNrtG9ty4kb2efgKFVW7lVSwrSsSXjtbGLBNgm0GsGdmX1xtqQHFQs1IjbGTyr_vOd0SCAYJ4cm-7G5SNSPU537rc7o1Z_98nQXKC41in4XnVe1YrSo0dJnnh5Pz6v3o8sip_vPnylmf8Ond-GLhB7ii_1z5cCZ-KAF9oQEgqoDoBiSOb8mMnleHLHJpROO4qpDYpaHXWq-1phEL2YyEAFFVOIkmlD-kEqiPGhCakoi4nEY9pN5ccHbDPMAckyCmVWVG_HDI3GfKryK2mAP3qvLi06UE6t707wajKoj44awfkDcaDTnhSgx_AG82e_JD6rX7Q8AhwQIQ1OrJbuAhj1ZAdT0PakC_ZgF11cqDbNPXNZhuFxDcgMwn2A35GswqoLcBWCTgC-Pghv2mGTFOgs51fwWpmZZzrOmOajuOZufq1p--xb5Lghvy6s8Ws2ufj8gzDTNknFyePX8y5SGEXy6yauUyvvQj-h68Fgu8d-FNCYvztbStfC3HNANYb-RG55y6pwjdDd0VglNE9j6EjKTRC_VKMUCUAXUZVAfyFNDSOGs2fQpVIBN6WCUKmU1omHB82x-DNyQkKyjLVgsNhcBZQxVS3WGoAvqbGAfojIi7ddb1YydfHT_yM_QttRhyl9fL4xygTiek0eRtOPVpkGGllQFPDdAi8xKYwqFZ9FKO3eR3UKQNyOTQ4Oy8kDhbSY2GXqyOhM9qoucHDg0oBQyPQpmBbXS_OP2I_UZd7geHoTWjGVtEJXZKVEECl_JFug20yUyY1lu45fadzniMarzQiwAagLJqrLBAziA4CLXJOXGf28yblDaaYHIQxqZ8w8V8jq0TGKQsAdzdBjT243WiHpkloO8gmLM5pxZtg-UZrKFLM1ht7uW5bKGU1wW35i02ZYBLM1i58waKxQyqJ7iVetCdrmvbsWrmemcB0VOmPRWAjJeC7bMlCD_FXjs-DBp6mHURyxUlouHvb6Xpb4CXYtAJvUWEuVCaxzbGLjYXi_E4VlyYCQjvgYfPq1XlCd6lz-4iiqn8MaKzOYtIoAA5P4wTAiN_BqU4jtuEE8VLuucHEvkk5LqYS2JKIneKNC5JEDxBLUHC67fil5hlLv0AJp42vEOpUbNtihpSRMZnJ2L4wqcuisUV-op_9UnE39IxSQCKN0An5n5IuJiwmkFQVYZTtmx6L8hpxFgQr2YrMp_DtLZBYxRRqpC0PrkohFAef8AsFoPUbzLkY9QmM-91gZBeVUKYy2BJr9tOvaY5jqPXLEszGzUTdkWjZugNS6vVVUu1anXD0us1q94wrJquNRyzVgc0u1bXTNWomXbDrsOfRqOm1c26WoMlvWaojuoAhKHBc8MBHqZjqlpN16HPrmmmXteBFowm8MbWDOCtG1rNNE3LAt42QEJHayEFU2vUbB2oWA3HrumOYas1p67VYckxzJrVsAynppuODsIBT1DGNExVsLBB6DqoYTUMYKepmmBRrzcAstEAhTUAt1RonQHcrGmWDerXLcsEEZxGvQY2ALPUHVWtWYZmwpoDwug6imQ5KghlgbyoDlCtmcAABGyoagNURtVMw4b38GShmhasWratATGAt5GdbdXsug7i10E5sJmKr8FO8KeK2jZMXQNZQAW9AXZGy9QNUNYEYN0EvTXgBi5o1FGKhqaCjBrqB52xAzAO2AJcY4FRNRAAzOwAYQx1l4Ueid6am3ER-hCGHEJra_RP100RZB_O7gc98fBhyvk8Pj05WS6Xx3PCp2xMX6GfOYb0PZkDEoTnUfzsB8ERUj1pwn8Xk4-thyvfH7q9z09kMZr0xvGn8WRmzLwHsz96sBsLm1z82v7YWRLvevrFNltPv0fq4Nb-16h76YMVj_jcOGrc3fde6sve8Ldfbheqf8WcLxF7nrWtp6cv5kWb2sb9S2j6dBSF2uvHi0HrdXjffG5-ibj3tTm5vru7mjfvl9HTbw9W35_ze-_uqj65-3w5mH1ufTVn-vDh8fP06Td9fO2-hlb4MB4cuV_rb6Pbdu_291-MR7v1r4sj_szs5Tj4lf3auzSWrftHO2z3Gob_-LHZFIY6SS11Js9G4hP5C7etyIcMlGY8g44m8p8WnKYLUB5eb5MUFa7Pxrn0t4y3bIomMY8-3pGiMjtluGfTUyamjPtsYsroFdksU0rmpcxAEZQyRWWUiRQVASzCU1aUJPRFdMskkUEvgzGpPSItMQ2qih_yRGmIUR4lzzKAZRUReZhkoMhqmW9JXokSJbNUphEWimpi85MNo5-dYKkUdRtrKT7cMi7X8GX642yI4RvDfhDxKzqLL95gb7_EeWXr4Copxgg9pFzuM1mc8yqPFhT3jzFZBPj-44IEPu4NavZtTx7ehSyarY5kgBTsDdiDSoqjtzkaptnrJVU_4ar4XroTJC_FuVxzLVqLBG4shPNDN1h4tBsmvc1qtwnIEwqAZ454xOClgm9RWjH6cAYSiQ0eJOiGELhJIZH4VwF7IoGeUknOJnV1c11L11_ktorVZtVLNqOILcEGyPbbBdllVJWvGXNO6AwBbygnHrQBJ10ObjhBX5wI4dHOW9RDMku20tWKkixtGcJlizBxcEbpxLKouTQLeEAuixUBo0yg--HUkztzniK-tGEyamOogrjvN7W239KfKJmzsBOIxjidAJNwy9g9ebMT-lAvrGK5H_kQ6DCnkpk401j7Qa4o66VD_ZAmvnD5f0lSpD1v0vKunbO58M6k2Ka-dsZ2r_1_Z3g4M7GYfyLYvK_8sHr3ThdkaK6tL14q8u3_DX9evSazGY3uxqMpvWJeNg22Vg5ywsoH35Bfe0IuKWys8ClV5Op_bH_ApIMx8YKuoyl_c8h4OHkE2qLBkS0MPgpWAqIbzhdc6HVenfmx-4gzNl7Wic5L3DR2Li87rVH3oZMM1lkUYe_HcDF7QqHk3zgfSMghFUeHSrx4iuXjefXBp0shSBvs7gcx2ikIyDymq8lWtC-J5AHgFVATUNc-l5tPHq01QD6lziuNYBCffILpP_Jprlyr9T1CSYZ4Io0HEXnU2qxIO3nA2YIxfkB4Lg1xglVApRX5PFcdXCzA7c7mJMjlnKzusQTHLhWSxh_7LoZ6scuxp5VQBXZx3UVE3LcCfyens_k0LgK0Wg4BuVigV4D9YI4WuJaP2md-jKfpu5GT1QKHTEI_PxSS1Xz0NnVJrtnkYj5yj1J3egU1noXXeMu1m8oKqoDSLQtFfmDL6wfY1eUGBfSXK5B8gndQhaPkoCuP0g2UtxSkMOfkCJ5LJwNRYCtxVZxjIVzLR5V3pzk64FpBXCb3j3mFwi_O9s1bwhx_ZGHySclj-VwbJkf8BW5IbrdyXCBXCzRJr_hylEiWCxJFlO_mC_M9ec2TkzJbYEX1hrnP309G3F19P5nty6zvp3gZkPg519_Jaj76PfexMdtBRTZTpYhgYn0fBcyv76OAVxqzd2MPtruYNe6guH9ZXb7sRE5Xi3I_uZN5NwV5c_RudHGx9W5ssQG06ZiCBoU7wAqmIDn4ImyDMXhBYpQkJcTaXUXW2h1ES-6FOzU9mKLM7uT7p6ICIEH2EILN_Lqg0yxHaXU_e01JwKd9xoLvI_jNd17fQwy_MVnMSeil5O529fdrP5S0HuMx0BT3hm38lOV7bRjS2dsOQvlynZ2kE6G4UcQZLbkHHfIIB_3fGZt9gXHTbljHddvQdKdu2PJ1L_3KNDmdht697YMXIxF9KVeE_HxePbJN69jRHd1WG07Dlt_dnInJOzk5x-fVwXk-vUVMh-L2Sp5CCgxpKDmjApX0oEDcc2ZOxAfwmr-dKve33Y_3nUofWlVOo78DmfgfsTKk0QsgVUYsCpWrAAa4uCJ7HkU2PaeKplWSW99TpR9RRT3WjjOvWosIZOUVObxST1mt6JXkrB8e1QpMT4HvQsacKmrlj0TYU-3PP6AMT-ipemz9-dMP1pGm_vg3hTMFvwxRZN-EtaQEBn7qcRjG-sh7F5qeRcMOX0lR2VhZnQMrMrgUEiudVx4RKYZ8-V5a2ySFLf5akmvVE7qGsRuxxUJIevRrauJDELKSl0L4Ri484rlh3gBVVYTC51XQOA3x5JgvF0LfC2HshTD3Qlh7Iep7Iey9EM5eiPRjWHG4t64M0hAb1WDQHHQqt1D3EKDSeZ2DB5Q2pKs8BlMu2LLSisgY3HKqYA2qQOqP_ddTJYk67c8ec0nQ9DzqYVhId2nq4-MKEsZeuvljuBiX-ZEtG8kN8qkyxP8rg0VIE6jdj6I-D-jXU8V2sjVHq_zBySQ-JeKQ6U_QT5HnTbEyxiAloUI8z8ctRdy-RGAAUC5W6gbGZcPaCP6_Jiq3_bRdwY2dFbw1ZU80whsJ-Av0JR6F0h1RwqfilPYvqdZrMxrGZun-SVNVpQt7SBD4E9ykoHh-XYAJMatziu4Pjnqk6Vib_NAFSWF_VtIPL4sLm3DBD5ZzVLd-RD_8oKn6kQZl7lv8bI1HfqoqMGayI1Jw1sky-clScVmeEmTl_smS2wm8FvSh-VHk-Vqlm0gPu3eIe03ysWiM8Dd-iJ1JWmiDmClEdHfKG1v8z5WxrdDGW_r8HmbzAj9gXPEBp_90P-hhNybP3mVzUhVL3azR8hAkG0Vboxj7UMTAmsVQVxiiDHU9ABcfkeGi-BQrRf2FLmmgJK-ypPewbM4WAeW7OOYgiIlbMQ7G0A7AkHbQS9pBfB23aYfk1QF2SLyll7a9qTW2bS9eHcDzggaHWD4NKGW4xG9vS-MNcEPVD0C4YN6bkh4JHiqe_i7xtIPj6RCFrimM8byka8XnfpuuTV4d4lrGePwNQ1mV5AUhzn6wdQ7F3PeJYt8Zy-FQzGfi3pCFY3-STGryRzKrCfzVG4X7PKB4oyA-Z9qsZ9n7Q4qjaje-YPivEdMLR2xbUnWywC6DhoMtw83ryeZDZ9C86qQI_YC4dAqA0BFkeMhLstUNpa2qexBwt0s_8U-xrD04m_90IoNnOyW4ISaE7HNI43goGrE1Bb1A3OEUYmYbQdvDMPnXHSwIxK6VtUwBJ5eJI4HSrGJ_4gd3Y3G0B2jifLIEGuwA3IcOi0affDz0op7g2cILdejTxhki-1ySFo0UoaE6VglfbHvQ2BcuqwuHlR11Mx-lNcXL7d12PDtZpZE8mRG_fq6cnXzzD33_DXJJFOQ=

Before (Base) /After (Average) screenshot:

now-and-again

Captura de tela 2025-01-21 064148

@igorwessel igorwessel marked this pull request as ready for review January 21, 2025 09:53
Comment on lines +1261 to +1262
local effectiveCooldownMultiplier = 1 - noCooldownChance
local effectiveCooldown = cooldown * effectiveCooldownMultiplier
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: ‏maybe calcSkillDown should be responsible to return this values.

@igorwessel igorwessel closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Chronomancer Ascendancy
1 participant