Grant Skills from node / item now can add support gem #589
+152
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjuangui
force-pushed
the
gem_redisign
branch
2 times, most recently
from
c7db171 to
31170df
Compare
justjuangui
force-pushed
the
gem_redisign
branch
from
31170df to
d72e640
Compare
justjuangui
force-pushed
the
gem_redisign
branch
from
d8a8092 to
8e7743f
Compare
justjuangui
force-pushed
the
gem_redisign
branch
from
8e7743f to
478ee51
Compare
justjuangui
force-pushed
the
gem_redisign
branch
2 times, most recently
from
37c2a13 to
4888b13
Compare
justjuangui
force-pushed
the
gem_redisign
branch
from
4888b13 to
1e743d5
Compare
Wires77
reviewed
Apr 22, 2025
| @@ -208,41 +206,6 @@ local SkillsTabClass = newClass("SkillsTab", "UndoHandler", "ControlHost", "Cont | |||
| self.controls.groupCount.shown = function() | |||
| return self.displayGroup.source ~= nil | |||
| end | |||
| self.controls.sourceNote = new("LabelControl", { "TOPLEFT", self.controls.groupSlotLabel, "TOPLEFT" }, { 0, 30, 0, 16 }) | |||
There was a problem hiding this comment.
Something funny happens when I allocate Explosive Impact on the tree. I'm assuming it's relating to removing this section. Do we need to remove it?
There was a problem hiding this comment.
Thx i didnt realice that kind of source, fixed in the last code
Comment on lines
+1091
to
+1110
| socketGroup.set1 = true | ||
| socketGroup.set2 = true |
There was a problem hiding this comment.
Can you not set a skill from a node to a weapon slot in-game?
There was a problem hiding this comment.
can you elaborate more please, i would like to understand your point
src/Modules/CalcSetup.lua
Outdated
| @@ -175,7 +175,7 @@ function calcs.buildModListForNode(env, node, incSmallPassiveSkill) | |||
| t_insert(node.grantedSkills, { | |||
| skillId = skill.skillId, | |||
| level = skill.level, | |||
| noSupports = true, | |||
| noSupports = skill.noSupports ~= nil and skill.noSupports, | |||
There was a problem hiding this comment.
Can't you just do skill.noSupports? That's what is in Item.lua
justjuangui
force-pushed
the
gem_redisign
branch
5 times, most recently
from
735c844 to
bc07eae
Compare
added 9 commits
May 1, 2025 18:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grant skill from nodes:
Grant skill from item:
Gems:
This PR also introduce the concept of "Set" with the following rule:
Now to precalculate by skill we are taking into account if the gem is from item and if slot have swap to change the option
Triggered Skills isnt yet implemented in POB2