Skip to content

Use slider instead of text editor for ring quality #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Use slider instead of text editor for ring quality #650

wants to merge 1 commit into from
+8 −17

Conversation

nessgor
Copy link
Contributor

@nessgor nessgor commented Jan 29, 2025

Fixes #613.

Description of the problem being solved:

  • Use a slider instead of a text editor for the quality of the ring/amulet (catalyst).
  • Breach Ring: 0% - 50%
  • Other rings and amulets: 0% - 20%

Steps taken to verify a working solution:

  • Tested on POB2
  • Automatic tests successful
image

Link to a build that showcases this PR:

https://pobb.in/_f7MFDiaTEBu

Before screenshot:

image image image

After screenshot:

image image image

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jan 30, 2025
@Wires77 Wires77 added user-interface Changes that only affect the UI and removed enhancement New feature, calculation, or mod labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
user-interface Changes that only affect the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quality slider for rings
3 participants
@nessgor @Wires77 @QuickStick123