fix curse limit is 1 more than expected #815
Open
+18
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799 .
Description of the problem being solved:
Marks and curse limit wew summed when assigning available curse slot resulting in curse limit increased by 1 if no mark were added. Moreover, if more than mark limit were in skill list, the first was chosen ignoring curse priority
Steps taken to verify a working solution:
Add multiple elemental curses and marks, with and without Whispers od Doom/Called Shots nodes and check which are selected in calcs tab debuff list
Link to a build that showcases this PR:
test build