fix: refuse to open overly long URLs #70
Conversation
|
This needs testing on affected Linux systems running Wine to see if the problem is mitigated, as the limits on proper Windows are higher. |
|
Experimental results on Wine 10 on Arch puts the upper limit for me at 1575. This could be very system and environment dependent. Couldn't find any obvious cause in Wine. |
There was a problem hiding this comment.
Just a quick test on Windows (non-Wine) shows that trade queries can easily be up to almost 3000 characters and still open fine. This hardcoded limit isn't going to work then without some significant changes on the Lua side.
Is it easy enough to test this with xdg-open instead?
The de facto limit for URL lengths under Wine on Linux seems to be somewhere around 1500 bytes, refuse to open the URL and return a reason as a string through the Lua API call.
zao
force-pushed
the
fix/check-url-length
branch
from
ee4c92f to
00e0bef
Compare
|
Starting native programs when running under Wine seems to be fairly unsupported. |
ShellExecute on Wine can crash if you feed it a too long URL and some browsers have been documented to have a fairly low max limit of 2083 characters.
This rejects URLs that are longer than 2048 characters.