Fix for use of ISRs with the RF69 driver on the ESP8266#28
Open
wvmarle wants to merge 2 commits intoPaulStoffregen:masterfrom
Open
Fix for use of ISRs with the RF69 driver on the ESP8266#28wvmarle wants to merge 2 commits intoPaulStoffregen:masterfrom
wvmarle wants to merge 2 commits intoPaulStoffregen:masterfrom
Conversation
added 2 commits
May 22, 2019 13:35
(note: the same change has to be done for other boards using interrupts)
(note: the same change has to be done for other boards using interrupts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISRs on the ESP8266 (and the ESP32) must be kept in IRAM rather than on Flash. This has always been the case (it prevents random crashes) but with the new 2.5.2. core this is enforced.
Other radios which use interrupts will have the same issue and need the same fix.