Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on tutorials page #60

Open
dlebauer opened this issue Jul 23, 2024 · 13 comments
Open

Broken links on tutorials page #60

dlebauer opened this issue Jul 23, 2024 · 13 comments
Assignees
Labels
docs This tag defined issues related to our documentation good first issue

Comments

@dlebauer
Copy link
Member

From the develop documentation page: https://pecanproject.github.io/documentation/develop/

What works:

Possible solutions:

  1. Fix the redirect
  2. Figure out if the issue exists on other pages & fix
  3. Another workaround would be to read the raw file content and display inside the docs thus:
@allgandalf allgandalf added the docs This tag defined issues related to our documentation label Jul 24, 2024
@allgandalf
Copy link
Collaborator

Checking if any contributor is interesting in handling the issue: https://pecanproject.slack.com/archives/C0853U6GF71/p1738574828197779?thread_ts=1738574404.433189&cid=C0853U6GF71

@harshagr70
Copy link

Hi @allgandalf , i guess i can tackle this issue well i very well know where the code is located and what needs to be fixed !! can you please assign this to me , thank you !!

@boss6825
Copy link
Contributor

boss6825 commented Feb 3, 2025

Hi @allgandalf , i guess i can tackle this issue well i very well know where the code is located and what needs to be fixed !! can you please assign this to me , thank you !!

already done with the work on issue so please don't start to work on this

@harshagr70
Copy link

Hey !! @boss6825 thanks for clarification , its good if you have already fixed this one , thanks !!

@dlebauer
Copy link
Member Author

@boss6825 awesome, please ping us in Slack once you submit a PR!

@allgandalf
Copy link
Collaborator

@boss6825 is the PR up? can you please link it for me? i couldn't find it 😢

@boss6825
Copy link
Contributor

Was working on this, currently tied up with college exams and some projects that i have to submit 🥲🥲
Will complete this as soon as i have some time 🙂

@subhrat123
Copy link

@boss6825 hey, if the issue is not solved yet, I would like to work upon it as I am new to open source I think this will be very much helpful for me to get started.

@harshagr70
Copy link

Hii @dlebauer i am ready with the solution for this , i aim to fix this now with the first solution you suggested !! and make it functional for now by redirecting the links out the frame restricting it to view inside the webpage , should i go ahead and raise a PR !?

@dlebauer
Copy link
Member Author

@harshagr70 yes, please do!

@allgandalf
Copy link
Collaborator

Assigned you for the issue @harshagr70 , please let us know once you have the PR up

@harshagr70
Copy link

@allgandalf The source RMD files are in the main repository (pecan) , i will raise a PR there and add a reference here !!

@harshagr70
Copy link

@allgandalf i have made the necessary changes in the source RMD file and tested the changes locally , they are working well as expected , the issue is that there are some links that i dont know currently which source or rmd files they must actually point to in order to fix them all !!
PR - PecanProject/pecan#3502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This tag defined issues related to our documentation good first issue
Projects
Status: To do
Development

No branches or pull requests

5 participants