Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pull Request template to instruct user to upload screenshots for mobile and desktop view #70

Closed
allgandalf opened this issue Feb 3, 2025 · 4 comments · Fixed by #78
Closed

Update Pull Request template to instruct user to upload screenshots for mobile and desktop view #70

allgandalf opened this issue Feb 3, 2025 · 4 comments · Fixed by #78
Assignees
@boss6825 @allgandalf
Labels
good first issue

Comments

@allgandalf
Copy link
Collaborator

allgandalf commented Feb 3, 2025 •
edited
Loading

Problem

Currently if anyone makes style changes / introduces a new component , they only include screenshot for large screens, but some style changes lead to very ugly UI for small screens. This causes a visual bug, while fixing one thing we break other things.

Proposal / Solution:

Include a Pull Request template for website repo which would require any pull request to include screenshots for large as well as small screens (Mobile) of the component where the changes were made.

Slack discussion: https://pecanproject.slack.com/archives/C01KZDVDXSQ/p1735928903512859
@allgandalf allgandalf self-assigned this Feb 3, 2025
@allgandalf
Copy link
Collaborator Author

allgandalf commented Feb 3, 2025 •
edited
Loading

The exact template details will be shared later, but happy to take proposals for this issue and get it done by a contributor

@boss6825
Copy link
Contributor

boss6825 commented Feb 3, 2025 •
edited
Loading

Image
created this PR template
@allgandalf can you suggest any more fixes ?
I will create PR then......

@allgandalf
Copy link
Collaborator Author

LGTM, can you create a PR for the same, i will suggest a few improvements over the PR

@allgandalf
Copy link
Collaborator Author

Assigned you to this issue as well! Looking forward to see you more involved with the community

boss6825 added a commit to boss6825/PecanProject.github.io that referenced this issue Feb 12, 2025
@boss6825
PecanProjectGH-70: Add PR template for mobile/desktop screenshots
a225bc9
boss6825 added a commit to boss6825/PecanProject.github.io that referenced this issue Feb 12, 2025
@boss6825
Merge pull request #1 from boss6825/PecanProjectGH-70-pr-template-mob…
091f239 
…ile-screenshots

PecanProjectGH-70: Add PR template for mobile/desktop screenshots
@boss6825 boss6825 mentioned this issue Feb 12, 2025
Merged
dlebauer added a commit that referenced this issue Feb 18, 2025
@dlebauer
Merge pull request #78 from boss6825/master
ae3a56e 
GH-#70: Add PR template requiring mobile and desktop screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boss6825 boss6825

@allgandalf allgandalf

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-#70: Add PR template requiring mobile and desktop screenshots boss6825/PecanProject.github.io
2 participants
@boss6825 @allgandalf