Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
npm publish
Browse files Browse the repository at this point in the history
  • Loading branch information
Stepan Miroshin committed May 9, 2016
1 parent 7e12024 commit cfcf10c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 53 deletions.
8 changes: 8 additions & 0 deletions .npmignore
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/.vscode
/node_modules
/build
/lib
/typings
.gitignore
tsconfig.json
tsd.json
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "buildjs/webcrypto.js",
"scripts": {
"test": "mocha",
"install": "tsd install && tsc && node-gyp rebuild"

This comment has been minimized.

Sign in to view

Copy link
@mitar

mitar May 11, 2016

Contributor

Why this change?

This comment has been minimized.

Sign in to view

Copy link
@microshine

microshine May 11, 2016

Contributor

Current install script for npm module. TSD and TSC compilation are no needed any more, because npm has comiled JS file

This comment has been minimized.

Sign in to view

Copy link
@mitar

mitar May 11, 2016

Contributor

Not for me? How does NPM know to do that?

This comment has been minimized.

Sign in to view

Copy link
@microshine

microshine May 11, 2016 •
edited
Loading

Contributor

package.json is pushed to NPM, so when you call npm install npm starts install script from package.json. Current version of npm module has no TS files, so it can't be compiled

This comment has been minimized.

Sign in to view

Copy link
@mitar

mitar May 11, 2016

Contributor

But npm install https://github.com/PeculiarVentures/node-webcrypto-ossl.git does not work.

This comment has been minimized.

Sign in to view

Copy link
@mitar

mitar May 11, 2016

Contributor

Or git clone https://github.com/PeculiarVentures/node-webcrypto-ossl.git && cd node-webcrypto-ossl && npm install does not work either.

This comment has been minimized.

Sign in to view

Copy link
@microshine

microshine May 11, 2016 •
edited
Loading

Contributor

try npm install node-webcrypto-ossl.
if you want to use the latest code you should compile module by yourself.

git clone https://github.com/PeculiarVentures/node-webcrypto-ossl.git
cd node-webcrypto-ossl
tsd install
tsc
npm install

This comment has been minimized.

Sign in to view

Copy link
@mitar

mitar May 11, 2016

Contributor

This is bad. This means I cannot use yet unpublished git version directly as a package dependency. Moreover, it means I cannot use a fork of this package directly.

Please make it so that npm install https://github.com/PeculiarVentures/node-webcrypto-ossl.git works out of the box.

This comment has been minimized.

Sign in to view

Copy link
@microshine

microshine May 11, 2016

Contributor

Ok. I think it can be fixed in the next commit
"install": "node-gyp rebuild"
},
"author": "PeculiarVentures",
"license": "MIT",
Expand Down
52 changes: 0 additions & 52 deletions test.js
View file

This file was deleted.

0 comments on commit cfcf10c

Please sign in to comment.