Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail early if we run out of disk space on the destination #506

Closed
matyasselmeci opened this issue Dec 15, 2023 · 1 comment · Fixed by #674
Closed

Bail early if we run out of disk space on the destination #506

matyasselmeci opened this issue Dec 15, 2023 · 1 comment · Fixed by #674
Assignees
Labels
client Issue affecting the OSDF client enhancement New feature or request
Milestone

Comments

@matyasselmeci
Copy link
Contributor

If stash_plugin is downloading multiple files and fills up the disk with one of them, it keeps going through the file list and trying the rest of the files. This is kind of inefficient -- it should just bail out early.

It would also be useful to delete any partially downloaded file(s) so we have enough room to write the output classad to report the failure.

@matyasselmeci matyasselmeci added the enhancement New feature or request label Dec 15, 2023
@bbockelm bbockelm added the client Issue affecting the OSDF client label Dec 21, 2023
@Todd-L-Miller
Copy link

Todd-L-Miller commented Dec 21, 2023

In the relatively near future, I would prefer to preallocate space for the output ClassAd and maybe leave the disk full (so that HTCondor properly/automatically reports it), especially if the disk is full because of something else going on with the system.

That may not change the action on this ticket at all, but I thought it was worth mentioning.

@bbockelm bbockelm added this to the v7.5.0 milestone Jan 2, 2024
@joereuss12 joereuss12 linked a pull request Jan 10, 2024 that will close this issue
@joereuss12 joereuss12 linked a pull request Jan 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issue affecting the OSDF client enhancement New feature or request
Projects
None yet
4 participants