Have pelican plugin move files in parallel #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a work in progress so setting as a draft. |
|
Smoke tests seem to show that this is working how it should, ready for review. |
|
Haven't had time for a full review but to provide some early feedback: This is approximately the design of the current parallel download when moving a directory. I want to improve things, however, by having the result of individual transfers be returned on a channel. That means there's a single for-loop that's both writing new tasks and reading results. For example of what this would give us: right now, there's a hard synchronization -- all transfers must complete before the overall process can fail. We know that we instead will want to fail all of them after the first transfer fails in the case of inputs. |
Now the plugin can move files just like handle_http does, starts up many workers and has a producer/consumer setup to download files in parallel.
Allows us to bail early if we encounter a failure on downloads
joereuss12
force-pushed
the
stash-plugin-move-files-parallel-branch
branch
from
4bd4966 to
33d1d5d
Compare
This was
linked to
issues
Jan 23, 2024
Now just has 1 for loop for sending work and interpreting results as soon as we get them. The plugin should bail early if a download/any error happens.
joereuss12
requested review from
jhiemstrawisc
and removed request for
bbockelm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the plugin can move files just like handle_http does, starts up many workers and has a producer/consumer setup to download files in parallel.