-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb Lotman config through to XRootD purge plugin #1935
Conversation
This finally gives Lotman some teeth in the cache. Now that we're running the correct patched version of xrootd, we can configure XRootD to use the lotman purge plugin.
The Lotman purge plugin relies on these parameters to function correctly, so they need to be made configurable. Most of the churn in this commit relates to validating/parsing the watermark values, which may be passed as an integer-encoded percentage or an absolute byte count.
For the reviewer, I think the bar for approval of this PR is that: To test these, you'll need to make sure you're running in a dev container that was built from a very recent You'll also need to make sure you're running a linux After that, you should be able to set:
in your configuration. Doing so must result in an extra line of xrootd configuration being populated, which will look something like
If you want to change the location of the lotman database from its default
which should update the xrootd configuration. If this extra xrootd line doesn't appear when lotman is enabled, or it appears when lotman isn't enabled, something is wrong. The presence of this extra configuration must not prevent the cache from fully initializing/booting. If all that happens, I think I'm happy at this stage. There may be some extra future work to validate certain types of parameters for Lotman, but as you'll see in a comment, I'm punting on that because it's complicated and XRootD will handle it anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This finally gives Lotman some teeth in the cache. Now that we're running the correct patched version of xrootd, we can configure XRootD to use the lotman purge plugin.