Add Cache and Server Cards to Map #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add more data onClick to the map server components
h2zh
requested changes
Feb 17, 2025
| <InformationSpan name={'URL'} value={server.url} /> | ||
| <InformationSpan | ||
| name={'Longitude'} | ||
| value={server.longitude.toString()} |
There was a problem hiding this comment.
I vaguely remember from my React class that in JSX, React can automatically convert numbers to strings when rendering them. So toString() here and the one on line 30 can be waived.
There was a problem hiding this comment.
Yeah, it does but I have the InformationSpan typed like so.
export const InformationSpan = ({
name,
value,
indent = 0,
}: {
name: string;
value: string;
indent?: number;
}) => {
So I just cast it to pass the type check. To be fair I could accept quite a few more values and have more lenient typing I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redacted to prevent scope creep (This is ready, but I would like to tack on a couple items before merge and need the director data to work first)
#1778