-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test improvements #2033
Open
brianaydemir
wants to merge
5
commits into
PelicanPlatform:main
Choose a base branch
from
brianaydemir:build-and-test-speedups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Build and test improvements #2033
brianaydemir
wants to merge
5
commits into
PelicanPlatform:main
from
brianaydemir:build-and-test-speedups
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e68070
to
8ea1e52
Compare
7480fb9
to
1aad23a
Compare
While it's challenging to acquire a statistically significant set of observations, I feel that addressing the two points in #2034 has resulted in some improvements to run times. Before:
After: (When looking at those runs, do be aware that improvements to the Windows tests are 100% due to #2030.) |
What are the CI failures about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
GitHub Actions, Release management, and CI
internal
Internal code improvements, not user-facing
test
Improvements to the test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to motivations listed in #2034, I've taken this opportunity to make the textual definitions for the various testing workflows more similar to each other.