Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI crashes #2037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix UI crashes #2037

wants to merge 1 commit into from
+10 −6

Conversation

patrickbrophy
Copy link
Collaborator

This PR addresses #2036. This PR adds some fallbacks to some locations where data was null or undefined.

@patrickbrophy patrickbrophy added bug Something isn't working javascript Pull requests that update Javascript code web-ui Related to our web displays labels Feb 24, 2025
@patrickbrophy patrickbrophy added this to the v7.14 milestone Feb 24, 2025
@patrickbrophy patrickbrophy requested a review from h2zh February 24, 2025 15:59
@patrickbrophy patrickbrophy linked an issue Feb 24, 2025 that may be closed by this pull request
Director UI is running into an unexpected error #2036
Open
@patrickbrophy patrickbrophy marked this pull request as ready for review February 24, 2025 15:59
@h2zh
Copy link
Collaborator

h2zh commented Feb 24, 2025

Hey @CannonLock, could you read through this PR? It seems like the problem is somehow stemmed from other frontend PR previously merged. Just want to see if you can recall anything else that need to amend too!

@h2zh h2zh requested a review from CannonLock February 24, 2025 17:43
CannonLock
CannonLock requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@CannonLock CannonLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Rather then casting undefined to '' in the sort in the StorageTable if would be better to remove Storage objects without a serverName in line 140.

if(serverName === undefined){
  return acc
  }

@h2zh
Copy link
Collaborator

h2zh commented Feb 24, 2025 •
edited
Loading

After fixing the linter issue, could you squash all commits in this PR into one commit (e.g. using git rebase -i HEAD~#NUMBER_OF_COMMITS)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CannonLock CannonLock CannonLock requested changes

@h2zh h2zh Awaiting requested review from h2zh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working javascript Pull requests that update Javascript code web-ui Related to our web displays
Projects
None yet
Milestone
v7.14
Development

Successfully merging this pull request may close these issues.

Director UI is running into an unexpected error
3 participants
@patrickbrophy @h2zh @CannonLock